jdaugherty commented on PR #16534: URL: https://github.com/apache/grails-core/pull/16534#issuecomment-6007697356
> @jdaugherty could you find supporting evidence before jumping to conclusions? Something is broken, this is just the first swing by an agent to try to figure it out. > > Maybe you are right, maybe there is not enough memory on the runners for the complex CI process. The PR description from the agent could be many things. @jamesfredley The PR stated that the hibernate 7 runs have been failing. I've merged 55+ PRs since Thursday, and out of all of those PRs, I don't recall seeing any of the hibernate runs fail with the description this PR gives. Since I haven't seen that in 8.0.x, and this PR is claiming there's an issue with 8.1 / 9.x, that's a strong indicator we have a memory problem that we introduced. I'm highly against retries or resets to work around CI problems. All we do is mask the problem for larger applications. We should instead dig into why they're failing. I made changes in #16376 to reduce the memory usage significantly and from my testing in that PR over a gig was still free on the Mac OS runners - which are further constrained than the other runners. If we're getting OOMs, we've introduced something to cause it. We should try to locate that instead of masking the symptom. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
