Copilot commented on code in PR #16560:
URL: https://github.com/apache/grails-core/pull/16560#discussion_r4226578176
##########
dependencies.gradle:
##########
@@ -77,12 +77,11 @@ ext {
'checker-qual.version' : '3.55.1',
'commons-codec.version' : '1.22.1',
'geb-spock.version' : '8.0.1',
- // Pinned deliberately as a drift tripwire even though it matches
Spring Boot's
- // managed version: graphql-java-extended-scalars (below) is NOT
managed by Spring
- // Boot and must be upgraded in lockstep with graphql-java.
Keeping this pin makes
- // the dependency validator flag any Spring Boot graphql-java bump
so we re-check
- // extended-scalars compatibility. See
https://github.com/apache/grails-core/issues/15674
- 'graphql-java.version' : '25.0',
+ // Pinned as a drift tripwire: graphql-java-extended-scalars is
not managed by Spring
+ // Boot and must move in lockstep. 25.1 is the version Spring Boot
4.1.2 has merged.
+ // The pin stays after that release so a later Boot bump still
forces an extended-scalars check.
Review Comment:
“Must move in lockstep” contradicts the adjacent versions: this change moves
graphql-java to 25.1 while extended-scalars remains at 24.0. The linked audit
describes the tripwire as requiring a compatibility check, not necessarily an
equal-version upgrade; wording it that way avoids misleading the next
dependency update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
