codecov[bot] commented on PR #16588: URL: https://github.com/apache/grails-core/pull/16588#issuecomment-6104613923
## [Codecov](https://app.codecov.io/gh/apache/grails-core/pull/16588?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `90.31311%` with `198 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 62.8836%. Comparing base ([`763bb7d`](https://app.codecov.io/gh/apache/grails-core/commit/763bb7d854e253d940ed7c7ff26d1ef7c3ae79b4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`514d197`](https://app.codecov.io/gh/apache/grails-core/commit/514d197580264b6106bf32cc71e45f51200d77fd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/grails-core/pull/16588?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...rails/datastore/gorm/jdbc/RelaxedDataBinder.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16588?src=pr&el=tree&filepath=grails-datamapping-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatastore%2Fgorm%2Fjdbc%2FRelaxedDataBinder.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFtYXBwaW5nLWNvcmUvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvZGF0YXN0b3JlL2dvcm0vamRiYy9SZWxheGVkRGF0YUJpbmRlci5ncm9vdnk=) | 71.0059% | [39 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...-core/src/main/groovy/grails/gorm/PagedList.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16588?src=pr&el=tree&filepath=grails-datamapping-core%2Fsrc%2Fmain%2Fgroovy%2Fgrails%2Fgorm%2FPagedList.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFtYXBwaW5nLWNvcmUvc3JjL21haW4vZ3Jvb3Z5L2dyYWlscy9nb3JtL1BhZ2VkTGlzdC5ncm9vdnk=) | 0.0000% | [23 Missing :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...grails/datastore/gorm/finders/DynamicFinder.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16588?src=pr&el=tree&filepath=grails-datamapping-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatastore%2Fgorm%2Ffinders%2FDynamicFinder.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFtYXBwaW5nLWNvcmUvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvZGF0YXN0b3JlL2dvcm0vZmluZGVycy9EeW5hbWljRmluZGVyLmdyb292eQ==) | 92.0578% | [12 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...src/main/groovy/grails/gorm/PagedResultList.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16588?src=pr&el=tree&filepath=grails-datamapping-core%2Fsrc%2Fmain%2Fgroovy%2Fgrails%2Fgorm%2FPagedResultList.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFtYXBwaW5nLWNvcmUvc3JjL21haW4vZ3Jvb3Z5L2dyYWlscy9nb3JtL1BhZ2VkUmVzdWx0TGlzdC5ncm9vdnk=) | 77.1930% | [13 Missing :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ils/datastore/gorm/query/AbstractResultList.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16588?src=pr&el=tree&filepath=grails-datamapping-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatastore%2Fgorm%2Fquery%2FAbstractResultList.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFtYXBwaW5nLWNvcmUvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvZGF0YXN0b3JlL2dvcm0vcXVlcnkvQWJzdHJhY3RSZXN1bHRMaXN0Lmdyb292eQ==) | 83.5443% | [4 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rails/datastore/gorm/jdbc/DataSourceBuilder.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16588?src=pr&el=tree&filepath=grails-datamapping-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatastore%2Fgorm%2Fjdbc%2FDataSourceBuilder.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFtYXBwaW5nLWNvcmUvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvZGF0YXN0b3JlL2dvcm0vamRiYy9EYXRhU291cmNlQnVpbGRlci5ncm9vdnk=) | 85.5263% | [6 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...tore/gorm/transform/AstPropertyResolveUtils.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16588?src=pr&el=tree&filepath=grails-datamapping-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatastore%2Fgorm%2Ftransform%2FAstPropertyResolveUtils.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFtYXBwaW5nLWNvcmUvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvZGF0YXN0b3JlL2dvcm0vdHJhbnNmb3JtL0FzdFByb3BlcnR5UmVzb2x2ZVV0aWxzLmdyb292eQ==) | 83.3333% | [5 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...nnections/DataSourceConnectionSourceFactory.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16588?src=pr&el=tree&filepath=grails-datamapping-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatastore%2Fgorm%2Fjdbc%2Fconnections%2FDataSourceConnectionSourceFactory.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFtYXBwaW5nLWNvcmUvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvZGF0YXN0b3JlL2dvcm0vamRiYy9jb25uZWN0aW9ucy9EYXRhU291cmNlQ29ubmVjdGlvblNvdXJjZUZhY3RvcnkuZ3Jvb3Z5) | 77.5000% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...che/grails/datamapping/aot/GormRuntimeHints.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16588?src=pr&el=tree&filepath=grails-datamapping-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fapache%2Fgrails%2Fdatamapping%2Faot%2FGormRuntimeHints.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFtYXBwaW5nLWNvcmUvc3JjL21haW4vZ3Jvb3Z5L29yZy9hcGFjaGUvZ3JhaWxzL2RhdGFtYXBwaW5nL2FvdC9Hb3JtUnVudGltZUhpbnRzLmdyb292eQ==) | 64.2857% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...s/datastore/gorm/events/DomainEventListener.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16588?src=pr&el=tree&filepath=grails-datamapping-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatastore%2Fgorm%2Fevents%2FDomainEventListener.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFtYXBwaW5nLWNvcmUvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvZGF0YXN0b3JlL2dvcm0vZXZlbnRzL0RvbWFpbkV2ZW50TGlzdGVuZXIuZ3Jvb3Z5) | 95.8333% | [1 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | ... and [17 more](https://app.codecov.io/gh/apache/grails-core/pull/16588?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/grails-core/pull/16588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## refactor/java-to-groovy-datamapping-validation #16588 +/- ## ======================================================================================== - Coverage 62.9404% 62.8836% -0.0568% - Complexity 29301 29634 +333 ======================================================================================== Files 2221 2221 Lines 109529 109321 -208 Branches 20139 20162 +23 ======================================================================================== - Hits 68938 68745 -193 + Misses 31347 31245 -102 - Partials 9244 9331 +87 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/grails-core/pull/16588?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../gorm/bootstrap/support/InstanceFactoryBean.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16588?src=pr&el=tree&filepath=grails-datamapping-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatastore%2Fgorm%2Fbootstrap%2Fsupport%2FInstanceFactoryBean.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFtYXBwaW5nLWNvcmUvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvZGF0YXN0b3JlL2dvcm0vYm9vdHN0cmFwL3N1cHBvcnQvSW5zdGFuY2VGYWN0b3J5QmVhbi5ncm9vdnk=) | `100.0000% <100.0000%> (ø)` | | | [...astore/gorm/finders/DynamicFinderInvocation.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16588?src=pr&el=tree&filepath=grails-datamapping-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatastore%2Fgorm%2Ffinders%2FDynamicFinderInvocation.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFtYXBwaW5nLWNvcmUvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvZGF0YXN0b3JlL2dvcm0vZmluZGVycy9EeW5hbWljRmluZGVySW52b2NhdGlvbi5ncm9vdnk=) | `100.0000% <100.0000%> (ø)` | | | [...grails/datastore/gorm/finders/FinderSupport.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16588?src=pr&el=tree&filepath=grails-datamapping-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatastore%2Fgorm%2Ffinders%2FFinderSupport.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFtYXBwaW5nLWNvcmUvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvZGF0YXN0b3JlL2dvcm0vZmluZGVycy9GaW5kZXJTdXBwb3J0Lmdyb292eQ==) | `80.0000% <100.0000%> (ø)` | | | [...ils/datastore/gorm/finders/ListResultFinder.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16588?src=pr&el=tree&filepath=grails-datamapping-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatastore%2Fgorm%2Ffinders%2FListResultFinder.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFtYXBwaW5nLWNvcmUvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvZGF0YXN0b3JlL2dvcm0vZmluZGVycy9MaXN0UmVzdWx0RmluZGVyLmdyb292eQ==) | `100.0000% <100.0000%> (ø)` | | | [...g/grails/datastore/gorm/jdbc/DatabaseDriver.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16588?src=pr&el=tree&filepath=grails-datamapping-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatastore%2Fgorm%2Fjdbc%2FDatabaseDriver.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFtYXBwaW5nLWNvcmUvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvZGF0YXN0b3JlL2dvcm0vamRiYy9EYXRhYmFzZURyaXZlci5ncm9vdnk=) | `85.1852% <100.0000%> (ø)` | | | [...ons/CachedDataSourceConnectionSourceFactory.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16588?src=pr&el=tree&filepath=grails-datamapping-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatastore%2Fgorm%2Fjdbc%2Fconnections%2FCachedDataSourceConnectionSourceFactory.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFtYXBwaW5nLWNvcmUvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvZGF0YXN0b3JlL2dvcm0vamRiYy9jb25uZWN0aW9ucy9DYWNoZWREYXRhU291cmNlQ29ubmVjdGlvblNvdXJjZUZhY3RvcnkuZ3Jvb3Z5) | `100.0000% <100.0000%> (ø)` | | | [...jdbc/connections/DataSourceConnectionSource.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16588?src=pr&el=tree&filepath=grails-datamapping-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatastore%2Fgorm%2Fjdbc%2Fconnections%2FDataSourceConnectionSource.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFtYXBwaW5nLWNvcmUvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvZGF0YXN0b3JlL2dvcm0vamRiYy9jb25uZWN0aW9ucy9EYXRhU291cmNlQ29ubmVjdGlvblNvdXJjZS5ncm9vdnk=) | `100.0000% <100.0000%> (ø)` | | | [...transform/DetachedCriteriaASTTransformation.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16588?src=pr&el=tree&filepath=grails-datamapping-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatastore%2Fgorm%2Fquery%2Ftransform%2FDetachedCriteriaASTTransformation.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFtYXBwaW5nLWNvcmUvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvZGF0YXN0b3JlL2dvcm0vcXVlcnkvdHJhbnNmb3JtL0RldGFjaGVkQ3JpdGVyaWFBU1RUcmFuc2Zvcm1hdGlvbi5ncm9vdnk=) | `100.0000% <100.0000%> (ø)` | | | [...query/transform/DetachedCriteriaTransformer.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16588?src=pr&el=tree&filepath=grails-datamapping-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatastore%2Fgorm%2Fquery%2Ftransform%2FDetachedCriteriaTransformer.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFtYXBwaW5nLWNvcmUvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvZGF0YXN0b3JlL2dvcm0vcXVlcnkvdHJhbnNmb3JtL0RldGFjaGVkQ3JpdGVyaWFUcmFuc2Zvcm1lci5ncm9vdnk=) | `79.4335% <ø> (ø)` | | | [.../query/transform/GormQuerySafetyTransformer.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16588?src=pr&el=tree&filepath=grails-datamapping-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatastore%2Fgorm%2Fquery%2Ftransform%2FGormQuerySafetyTransformer.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFtYXBwaW5nLWNvcmUvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvZGF0YXN0b3JlL2dvcm0vcXVlcnkvdHJhbnNmb3JtL0dvcm1RdWVyeVNhZmV0eVRyYW5zZm9ybWVyLmdyb292eQ==) | `83.6667% <ø> (ø)` | | | ... and [31 more](https://app.codecov.io/gh/apache/grails-core/pull/16588?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/apache/grails-core/pull/16588/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
