codecov[bot] commented on PR #16596: URL: https://github.com/apache/grails-core/pull/16596#issuecomment-6104664541
## [Codecov](https://app.codecov.io/gh/apache/grails-core/pull/16596?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `40.14118%` with `1272 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 62.7074%. Comparing base ([`fa3b80a`](https://app.codecov.io/gh/apache/grails-core/commit/fa3b80ac515890a82e061a7037bda11580da8103?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d45af4d`](https://app.codecov.io/gh/apache/grails-core/commit/d45af4d9adb7301b8c795dc9461fa3bb6e5435ea?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/grails-core/pull/16596?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../main/groovy/org/grails/web/json/JSONObject.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16596?src=pr&el=tree&filepath=grails-web-common%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fjson%2FJSONObject.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1jb21tb24vc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2pzb24vSlNPTk9iamVjdC5ncm9vdnk=) | 22.8000% | [187 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...c/main/groovy/org/grails/web/json/JSONArray.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16596?src=pr&el=tree&filepath=grails-web-common%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fjson%2FJSONArray.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1jb21tb24vc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2pzb24vSlNPTkFycmF5Lmdyb292eQ==) | 10.1911% | [139 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ils/web/json/PathCapturingJSONWriterWrapper.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16596?src=pr&el=tree&filepath=grails-web-common%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fjson%2FPathCapturingJSONWriterWrapper.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1jb21tb24vc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2pzb24vUGF0aENhcHR1cmluZ0pTT05Xcml0ZXJXcmFwcGVyLmdyb292eQ==) | 0.0000% | [120 Missing :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...main/groovy/org/grails/web/json/JSONTokener.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16596?src=pr&el=tree&filepath=grails-web-common%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fjson%2FJSONTokener.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1jb21tb24vc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2pzb24vSlNPTlRva2VuZXIuZ3Jvb3Z5) | 25.9542% | [90 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../web/util/BoundedCharsAsEncodedBytesCounter.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16596?src=pr&el=tree&filepath=grails-web-common%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Futil%2FBoundedCharsAsEncodedBytesCounter.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1jb21tb24vc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL3V0aWwvQm91bmRlZENoYXJzQXNFbmNvZGVkQnl0ZXNDb3VudGVyLmdyb292eQ==) | 2.5316% | [77 Missing :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rc/main/groovy/org/grails/web/util/WebUtils.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16596?src=pr&el=tree&filepath=grails-web-common%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Futil%2FWebUtils.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1jb21tb24vc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL3V0aWwvV2ViVXRpbHMuZ3Jvb3Z5) | 48.5507% | [67 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ovy/org/grails/web/servlet/GrailsFlashScope.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16596?src=pr&el=tree&filepath=grails-web-common%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fservlet%2FGrailsFlashScope.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1jb21tb24vc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL3NlcnZsZXQvR3JhaWxzRmxhc2hTY29wZS5ncm9vdnk=) | 29.6703% | [53 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...y/org/grails/web/json/PrettyPrintJSONWriter.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16596?src=pr&el=tree&filepath=grails-web-common%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fjson%2FPrettyPrintJSONWriter.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1jb21tb24vc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2pzb24vUHJldHR5UHJpbnRKU09OV3JpdGVyLmdyb292eQ==) | 0.0000% | [56 Missing :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/grails/web/util/IncludeResponseWrapper.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16596?src=pr&el=tree&filepath=grails-web-common%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Futil%2FIncludeResponseWrapper.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1jb21tb24vc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL3V0aWwvSW5jbHVkZVJlc3BvbnNlV3JhcHBlci5ncm9vdnk=) | 9.8361% | [53 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ls/web/errors/GrailsWrappedRuntimeException.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16596?src=pr&el=tree&filepath=grails-web-common%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Ferrors%2FGrailsWrappedRuntimeException.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1jb21tb24vc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2Vycm9ycy9HcmFpbHNXcmFwcGVkUnVudGltZUV4Y2VwdGlvbi5ncm9vdnk=) | 51.1905% | [39 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | ... and [23 more](https://app.codecov.io/gh/apache/grails-core/pull/16596?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/grails-core/pull/16596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## refactor/java-to-groovy-grails-gsp-core #16596 +/- ## ================================================================================= + Coverage 62.6533% 62.7074% +0.0541% - Complexity 30624 30747 +123 ================================================================================= Files 2216 2216 Lines 108719 108622 -97 Branches 20334 20390 +56 ================================================================================= - Hits 68116 68114 -2 + Misses 31021 30897 -124 - Partials 9582 9611 +29 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/grails-core/pull/16596?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ovy/grails/web/context/ServletContextHolder.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16596?src=pr&el=tree&filepath=grails-web-common%2Fsrc%2Fmain%2Fgroovy%2Fgrails%2Fweb%2Fcontext%2FServletContextHolder.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1jb21tb24vc3JjL21haW4vZ3Jvb3Z5L2dyYWlscy93ZWIvY29udGV4dC9TZXJ2bGV0Q29udGV4dEhvbGRlci5ncm9vdnk=) | `100.0000% <100.0000%> (ø)` | | | [...ngsource/DataBindingSourceCreationException.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16596?src=pr&el=tree&filepath=grails-web-common%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatabinding%2Fbindingsource%2FDataBindingSourceCreationException.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1jb21tb24vc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvZGF0YWJpbmRpbmcvYmluZGluZ3NvdXJjZS9EYXRhQmluZGluZ1NvdXJjZUNyZWF0aW9uRXhjZXB0aW9uLmdyb292eQ==) | `100.0000% <100.0000%> (ø)` | | | [...rg/grails/web/config/http/GrailsFilterOrder.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16596?src=pr&el=tree&filepath=grails-web-common%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconfig%2Fhttp%2FGrailsFilterOrder.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1jb21tb24vc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbmZpZy9odHRwL0dyYWlsc0ZpbHRlck9yZGVyLmdyb292eQ==) | `0.0000% <ø> (ø)` | | | [...vy/org/grails/web/config/http/GrailsFilters.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16596?src=pr&el=tree&filepath=grails-web-common%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconfig%2Fhttp%2FGrailsFilters.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1jb21tb24vc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbmZpZy9odHRwL0dyYWlsc0ZpbHRlcnMuZ3Jvb3Z5) | `100.0000% <100.0000%> (ø)` | | | [...in/groovy/org/grails/web/json/JSONException.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16596?src=pr&el=tree&filepath=grails-web-common%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fjson%2FJSONException.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1jb21tb24vc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2pzb24vSlNPTkV4Y2VwdGlvbi5ncm9vdnk=) | `100.0000% <100.0000%> (ø)` | | | [...n/groovy/org/grails/web/json/JsonDateFormat.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16596?src=pr&el=tree&filepath=grails-web-common%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fjson%2FJsonDateFormat.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1jb21tb24vc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2pzb24vSnNvbkRhdGVGb3JtYXQuZ3Jvb3Z5) | `95.8333% <100.0000%> (ø)` | | | [...rg/grails/web/servlet/WrappedResponseHolder.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16596?src=pr&el=tree&filepath=grails-web-common%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fservlet%2FWrappedResponseHolder.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1jb21tb24vc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL3NlcnZsZXQvV3JhcHBlZFJlc3BvbnNlSG9sZGVyLmdyb292eQ==) | `100.0000% <100.0000%> (ø)` | | | [...groovy/org/grails/web/util/HiddenHttpMethod.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16596?src=pr&el=tree&filepath=grails-web-common%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Futil%2FHiddenHttpMethod.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1jb21tb24vc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL3V0aWwvSGlkZGVuSHR0cE1ldGhvZC5ncm9vdnk=) | `90.9091% <100.0000%> (ø)` | | | [.../grails/web/context/WebRequestServletHolder.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16596?src=pr&el=tree&filepath=grails-web-common%2Fsrc%2Fmain%2Fgroovy%2Fgrails%2Fweb%2Fcontext%2FWebRequestServletHolder.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1jb21tb24vc3JjL21haW4vZ3Jvb3Z5L2dyYWlscy93ZWIvY29udGV4dC9XZWJSZXF1ZXN0U2VydmxldEhvbGRlci5ncm9vdnk=) | `75.0000% <66.6667%> (ø)` | | | [...grails/web/util/GrailsApplicationAttributes.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16596?src=pr&el=tree&filepath=grails-web-common%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Futil%2FGrailsApplicationAttributes.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLXdlYi1jb21tb24vc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL3V0aWwvR3JhaWxzQXBwbGljYXRpb25BdHRyaWJ1dGVzLmdyb292eQ==) | `0.0000% <0.0000%> (ø)` | | | ... and [31 more](https://app.codecov.io/gh/apache/grails-core/pull/16596?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/apache/grails-core/pull/16596/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
