amondel2 commented on code in PR #439:
URL:
https://github.com/apache/grails-intellij-plugin/pull/439#discussion_r4240270226
##########
AGENTS.md:
##########
@@ -162,13 +162,18 @@ both ordinary directories and module content roots, which
the platform presents
**Module content-root labels use coloured fragments; ordinary directories use
`presentableText`.**
In platform 262.10315.125, `PsiDirectoryNode.updateImpl` adds coloured
fragments only when
-`ProjectRootsUtil.isModuleContentRoot` is true. For other directories it calls
`setPresentableText`
-with the name from `ProjectViewDirectoryHelper.getNodeName`, which can be
qualified (`grails-app.i18n`).
+`ProjectRootsUtil.isModuleContentRoot` is true *and* the file resolves to at
least one module; a content
Review Comment:
Fixed both points. The `GrailsPsiDirectoryNode` javadoc now carries the same
rule as AGENTS.md — fragments appear only when the directory is a module
content root *and* the file resolves to at least one module — so neither file
invites the reading that a content root alone is enough. AGENTS.md also now
says the no-modules fall-through requires
`CodeInsightContexts.isSharedSourceSupportEnabled` to be on, since otherwise
`modules` is the singleton `fi.getModuleForFile(file)` list and is never empty.
##########
plugin/src/test/java/org/apache/grails/intellij/plugin/projectView/impl/GrailsNodeProviderTestSupport.java:
##########
@@ -100,7 +100,10 @@ protected static void assertTitleAndLocation(@Nullable
GrailsPsiDirectoryNode no
/**
* Reads a node the way the renderer does: {@code updateImpl} then {@code
postprocess}. The second call
Review Comment:
Fixed. The `rendered()` javadoc now names all three steps `update()` runs —
`updateImpl`, then the project-view decorators, then `postprocess` — and says
why going through `update()` matters rather than calling the two hooks
directly: the decorators sit between the hooks and can rewrite what
`updateImpl` wrote.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
