The GitHub Actions job "CodeQL" on grails-intellij-plugin.git/main has 
succeeded.
Run started by GitHub user jdaugherty (triggered by jdaugherty).

Head commit for run:
73363d7d413988cc6662677e7b22dff569e84197 / Aaron <[email protected]>
Correct node-label comments and pin the postprocess hook with a decorator test 
(#439)

Correct node-label comments and pin the postprocess hook with a decorator test 
(#439)

Follow-up to #432. Corrects the comments, javadoc and AGENTS.md text that
describe how GrailsPsiDirectoryNode titles a directory, and adds a
regression test for the hook order.

- postprocess runs only on the updated presentation, from
  PresentableNodeDescriptor.getUpdatedPresentation. It never labels the
  template: PresentationData.applyFrom fills only null or empty fields.
- PsiDirectoryNode.updateImpl adds coloured fragments only when the
  directory is a module content root and the file resolves to at least
  one module. The no-modules fall-through needs
  CodeInsightContexts.isSharedSourceSupportEnabled. Every other directory
  gets setPresentableText from ProjectViewDirectoryHelper.getNodeName and
  no fragments.
- The title write must stay in postprocess. AbstractPsiBasedNode.doUpdate
  runs updateImpl, then the ProjectViewNodeDecorators, and postprocess
  only afterwards. GradleModuleDirectoryDecorator rewrites content-root
  fragments, so a title written in updateImpl would be restyled or
  suffixed with [module].

testTitleSurvivesProjectViewDecorators registers a decorator shaped like
GradleModuleDirectoryDecorator's appendModuleName branch and asserts that
update() draws only the title. It fails if the write moves into
updateImpl.

Comments, documentation and tests only; no behavior change.

Report URL: 
https://github.com/apache/grails-intellij-plugin/actions/runs/38125023728

With regards,
GitHub Actions via GitBox

Reply via email to