gustavoharff commented on PR #16559:
URL: https://github.com/apache/grails-core/pull/16559#issuecomment-6109747655
> One non-blocking note: the `definition.path() != null` arm in
`PredicateGenerator` is not exercised, and `JpaCriteriaQueryCreator` never
registers a definition with a null path. Either drop the check or add a small
feature for it, as you prefer.
Dropped it in 6e74e9c366.
> On accepting `jakarta.persistence.criteria.JoinType` in the DSL: that
sounds fine to me as an addition. I don't remember whether the DSL accepts Java
types today, so it deserves its own PR with its own spec rather than riding on
this one.
Agreed, I'll open a separate PR with its own spec. For reference,
`DetachedCriteria.join(String, JoinType)` already takes the jakarta enum.
What's missing is the `createCriteria`/`withCriteria` builder, where
association blocks (`pets(LEFT_JOIN) { }`) and `createAlias` only take the int
constants. I'll wait for #16573 first, since `createAlias` ignores the join
type until it lands (#16562).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
