codecov[bot] commented on PR #16601: URL: https://github.com/apache/grails-core/pull/16601#issuecomment-6110038590
## [Codecov](https://app.codecov.io/gh/apache/grails-core/pull/16601?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `54.74820%` with `629 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 62.7005%. Comparing base ([`d45af4d`](https://app.codecov.io/gh/apache/grails-core/commit/d45af4d9adb7301b8c795dc9461fa3bb6e5435ea?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6df746b`](https://app.codecov.io/gh/apache/grails-core/commit/6df746b81d9231b22ae502a0bee9dd70b5c995d2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/grails-core/pull/16601?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ters/src/main/groovy/grails/converters/JSON.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Fgrails%2Fconverters%2FJSON.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L2dyYWlscy9jb252ZXJ0ZXJzL0pTT04uZ3Jvb3Z5) | 39.2857% | [134 Missing and 19 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rters/src/main/groovy/grails/converters/XML.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Fgrails%2Fconverters%2FXML.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L2dyYWlscy9jb252ZXJ0ZXJzL1hNTC5ncm9vdnk=) | 42.2460% | [98 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rters/marshaller/json/DomainClassMarshaller.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fmarshaller%2Fjson%2FDomainClassMarshaller.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvbWFyc2hhbGxlci9qc29uL0RvbWFpbkNsYXNzTWFyc2hhbGxlci5ncm9vdnk=) | 52.2727% | [39 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...erters/marshaller/xml/DomainClassMarshaller.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fmarshaller%2Fxml%2FDomainClassMarshaller.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvbWFyc2hhbGxlci94bWwvRG9tYWluQ2xhc3NNYXJzaGFsbGVyLmdyb292eQ==) | 45.8333% | [34 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ovy/org/grails/web/converters/ConverterUtil.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2FConverterUtil.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvQ29udmVydGVyVXRpbC5ncm9vdnk=) | 25.4902% | [29 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...s/marshaller/xml/ValidationErrorsMarshaller.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fmarshaller%2Fxml%2FValidationErrorsMarshaller.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvbWFyc2hhbGxlci94bWwvVmFsaWRhdGlvbkVycm9yc01hcnNoYWxsZXIuZ3Jvb3Z5) | 8.6956% | [21 Missing :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../marshaller/json/ValidationErrorsMarshaller.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fmarshaller%2Fjson%2FValidationErrorsMarshaller.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvbWFyc2hhbGxlci9qc29uL1ZhbGlkYXRpb25FcnJvcnNNYXJzaGFsbGVyLmdyb292eQ==) | 47.0588% | [14 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...configuration/ChainedConverterConfiguration.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fconfiguration%2FChainedConverterConfiguration.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvY29uZmlndXJhdGlvbi9DaGFpbmVkQ29udmVydGVyQ29uZmlndXJhdGlvbi5ncm9vdnk=) | 67.3469% | [8 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...nfiguration/ImmutableConverterConfiguration.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fconfiguration%2FImmutableConverterConfiguration.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvY29uZmlndXJhdGlvbi9JbW11dGFibGVDb252ZXJ0ZXJDb25maWd1cmF0aW9uLmdyb292eQ==) | 0.0000% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...guration/ConvertersConfigurationInitializer.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fconfiguration%2FConvertersConfigurationInitializer.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvY29uZmlndXJhdGlvbi9Db252ZXJ0ZXJzQ29uZmlndXJhdGlvbkluaXRpYWxpemVyLmdyb292eQ==) | 89.0511% | [8 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | ... and [39 more](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## refactor/java-to-groovy-grails-web-common #16601 +/- ## =================================================================================== - Coverage 62.7074% 62.7005% -0.0069% - Complexity 30747 30780 +33 =================================================================================== Files 2216 2216 Lines 108622 108433 -189 Branches 20390 20395 +5 =================================================================================== - Hits 68114 67988 -126 + Misses 30897 30806 -91 - Partials 9611 9639 +28 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/grails-core/pull/16601?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../groovy/org/grails/plugins/codecs/JSONCodec.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fplugins%2Fcodecs%2FJSONCodec.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvcGx1Z2lucy9jb2RlY3MvSlNPTkNvZGVjLmdyb292eQ==) | `100.0000% <100.0000%> (ø)` | | | [...n/groovy/org/grails/plugins/codecs/XMLCodec.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fplugins%2Fcodecs%2FXMLCodec.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvcGx1Z2lucy9jb2RlY3MvWE1MQ29kZWMuZ3Jvb3Z5) | `100.0000% <100.0000%> (ø)` | | | [.../groovy/org/grails/web/converters/Converter.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2FConverter.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvQ29udmVydGVyLmdyb292eQ==) | `75.0000% <100.0000%> (ø)` | | | [...aller/ByGrailsApplicationDomainClassFetcher.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fmarshaller%2FByGrailsApplicationDomainClassFetcher.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvbWFyc2hhbGxlci9CeUdyYWlsc0FwcGxpY2F0aW9uRG9tYWluQ2xhc3NGZXRjaGVyLmdyb292eQ==) | `100.0000% <100.0000%> (ø)` | | | [...erters/marshaller/json/CollectionMarshaller.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fmarshaller%2Fjson%2FCollectionMarshaller.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvbWFyc2hhbGxlci9qc29uL0NvbGxlY3Rpb25NYXJzaGFsbGVyLmdyb292eQ==) | `85.7143% <100.0000%> (ø)` | | | [...eb/converters/marshaller/json/MapMarshaller.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fmarshaller%2Fjson%2FMapMarshaller.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvbWFyc2hhbGxlci9qc29uL01hcE1hcnNoYWxsZXIuZ3Jvb3Z5) | `81.8182% <100.0000%> (ø)` | | | [...web/converters/marshaller/xml/MapMarshaller.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fmarshaller%2Fxml%2FMapMarshaller.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvbWFyc2hhbGxlci94bWwvTWFwTWFyc2hhbGxlci5ncm9vdnk=) | `87.5000% <100.0000%> (ø)` | | | [.../web/converters/ConvertersDomainTransformer.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fcompiler%2Fweb%2Fconverters%2FConvertersDomainTransformer.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvY29tcGlsZXIvd2ViL2NvbnZlcnRlcnMvQ29udmVydGVyc0RvbWFpblRyYW5zZm9ybWVyLmdyb292eQ==) | `80.0000% <80.0000%> (ø)` | | | [...grails/plugins/converters/api/ConvertersApi.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fplugins%2Fconverters%2Fapi%2FConvertersApi.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvcGx1Z2lucy9jb252ZXJ0ZXJzL2FwaS9Db252ZXJ0ZXJzQXBpLmdyb292eQ==) | `70.0000% <83.3333%> (ø)` | | | [...rs/configuration/ObjectMarshallerRegisterer.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree&filepath=grails-converters%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fweb%2Fconverters%2Fconfiguration%2FObjectMarshallerRegisterer.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWNvbnZlcnRlcnMvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvd2ViL2NvbnZlcnRlcnMvY29uZmlndXJhdGlvbi9PYmplY3RNYXJzaGFsbGVyUmVnaXN0ZXJlci5ncm9vdnk=) | `77.7778% <83.3333%> (ø)` | | | ... and [46 more](https://app.codecov.io/gh/apache/grails-core/pull/16601?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | ... and [9 files with indirect coverage changes](https://app.codecov.io/gh/apache/grails-core/pull/16601/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
