borinquenkid commented on PR #16532: URL: https://github.com/apache/grails-core/pull/16532#issuecomment-6259010046
Thanks for the thorough probes. All four points are addressed in 8ca766e5a5: 1. The circular test now saves through `addToFollowing` and asserts that both sides read back empty, so it checks the second half of its name and pins the difference from H5 (where #16656 keeps the circular exclusion). 2. and 3. The Many-to-Many guide now covers the circular shape: adding `belongsTo` changes the columns of both join tables (drop and recreate them, or migrate; `dbCreate: 'update'` leaves the old NOT NULL column), each property writes its own join table (use `addToFollowing`/`removeFromFollowing`, and remove a user from both sides before deleting it). 4. The self-referencing test is renamed to "a unidirectional self-referencing one-to-many logs no warning", the guide notes the `Map` exclusion, and the PR description now describes the final change. `ManyToManyWithoutOwnerWarningSpec` passes 9/9 on this head. Could you take another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
