borinquenkid opened a new pull request, #16680:
URL: https://github.com/apache/grails-core/pull/16680
Stacks on #16589 (java-to-groovy conversion for `grails-encoder`).
Idiom pass over that conversion's output: the conversion PR keeps the
original Java semicolons and double-quoted strings, under a
`@SuppressWarnings('UnnecessarySemicolon')` header and a
`TODO(groovyism-cleanup)` comment, so git still recognizes each `.java` ->
`.groovy` pair as a rename (see matrei's review on #16576). This PR removes
that scaffolding and applies the Groovy idioms CodeNarc expects.
**Verification**
- compile and CodeNarc of the module's own projects pass on this branch (the
tip carries the 10.0.x merge of the conversion PR)
- no tests were run locally for this stacked cleanup (compile and CodeNarc
only); CI on stacked PRs is disabled, see below
**CI note:** this stacked branch inherits the temporary `CHANGEME FOR
ACCEPTANCE` workflow-trigger commit from its base, so no CI runs on it. That
commit must be reverted, and CI green, before this PR merges (blocker).
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
