The GitHub Actions job "CI - Groovy Joint Validation Build" on 
grails-core.git/fix/async-rxjava3-null-promise has failed.
Run started by GitHub user jdaugherty (triggered by jdaugherty).

Head commit for run:
a474a77242058aaed81dbae38eef17674bd68316 / James Daugherty 
<[email protected]>
Carry null through the RxJava 3 promise factory

grails-async-rxjava3 did not behave like the other promise factories for a 
promise of null. RxJava 3 forbids
null in a stream and the factory passed it straight in: createPromise(), 
createPromise(Class) and onComplete
over a list holding a bound promise of null threw NullPointerException from 
Single.just/Observable.just, and
createPromise { null }.get() returned the java.lang.Void class that runCallable 
used as a sentinel and nothing
turned back. createPromise() is what Promises.createPromise() and 
WebPromises.createPromise() call.

RxPromise now carries null through the stream as a private sentinel and 
restores it wherever a value leaves
the stream: get(), the value an onComplete callback receives, and the lists 
onComplete, onError and waitAll
deliver. RxPromiseNullSpec covers each case and fails on the previous code; the 
result == Void assertion in
RxPromiseSpec becomes result == null.

Report URL: https://github.com/apache/grails-core/actions/runs/39468212038

With regards,
GitHub Actions via GitBox

Reply via email to