jdaugherty commented on PR #16690:
URL: https://github.com/apache/grails-core/pull/16690#issuecomment-6321652552
@jamesfredley these issues should be addressed.
- The bound branch of values() now emits Observable.fromCallable {
RxPromise.wrap(p.get()) }, so a stored failure errors the list and a successful
null is still wrapped. The javadoc says so.
- Two regressions in RxPromiseListSpec, each with a failed bound promise
placed after a task: list onError receives the failure and the aggregate get()
throws it, and list onComplete never runs its callback and its get() throws it.
Both fail against the old helper and pass with the fix. The bound-null coverage
in RxPromiseNullSpec is unchanged and still passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
