The GitHub Actions job "Code Style" on 
grails-core.git/fix/async-rxjava3-null-promise has failed.
Run started by GitHub user jdaugherty (triggered by jdaugherty).

Head commit for run:
1ccc1a8ec8a352cd3e27d869486febb0083321ff / James Daugherty 
<[email protected]>
Feedback:
- The bound branch of values() now emits Observable.fromCallable { 
RxPromise.wrap(p.get()) }, so a stored failure errors the list and a successful 
null is still wrapped. The javadoc says so.
- Two regressions in RxPromiseListSpec, each with a failed bound promise placed 
after a task: list onError receives the failure and the aggregate get() throws 
it, and list onComplete never runs its callback and its get() throws it. Both 
fail against the old helper and pass with the fix. The bound-null coverage in 
RxPromiseNullSpec is unchanged and still passes.

Report URL: https://github.com/apache/grails-core/actions/runs/39639300599

With regards,
GitHub Actions via GitBox

Reply via email to