jdaugherty commented on PR #16631: URL: https://github.com/apache/grails-core/pull/16631#issuecomment-6343657017
@jamesfredley the two line comments are answered on their threads. The three items from the review body are fixed in 43640050e9 as well: - **A runtime-added connection dropped the application's sql-tail settings.** `HibernateConnectionSourceFactory` (H7) and `AbstractHibernateConnectionSourceFactory` (H5) now read them with `SqlTailSettings.from(configuration, fallback)`, where the fallback is the sql-tail settings of the connection source it is built after. A connection added through `addConnectionSource` captures as the application does unless its own configuration says otherwise. Covered by `a data source added at runtime records as the application does` in both inspector specs, and by `SqlTailSettingsSpec`. - **Truncation was the only restart signal.** The first line of the capture now names the run (`# sql-tail capture <uuid>`), and `SqlTailFileReader` starts over when that line names a different run, as well as when the file shrinks. A file caught between the truncation and its header being written is picked up without a second restart. `SqlTailFileReaderSpec` covers a new run that grew past the old offset before the next poll; `SqlTailRunnerSpec` covers it end to end in the stream. - **Request totals versus page labels, and interleaved stream counts.** `SqlTailSummary` now keeps request statistics per page, so a page's MAX and most repeated statement count only what a request ran on that page; a forward, or a filter query before the controller is chosen, counts the request on each page with its own statements. `SqlTailRenderer` keeps a running count per request instead of dropping it when another request interleaves, heads a returning request as `(continued)`, keeps the 1000 most recent requests, and forgets them on a restart. Covered in `SqlTailSummarySpec`, `SqlTailRendererSpec` and `SqlTailRunnerSpec`. The guide section, the `sql-tail` reference page and What's New now describe the redaction and the capture lifecycle. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
