jdaugherty commented on PR #16631: URL: https://github.com/apache/grails-core/pull/16631#issuecomment-6382037533
@jamesfredley re your reviews 5636821537 and 5637351665: the comment-before-bracket leak is fixed on the current head, 54a6574fc5. `H2SqlSyntax` now treats the two characters that close a block comment like whitespace before a `[` (`afterGap` replaces `afterWhitespace` in both the readings decision and `endOfQuotedName`), so `ARRAY/**/['example-secret']` and `ARRAY /* c */['example-secret']` get the name reading and the array-literal reading and are withheld. Covered in `QueryTailRedactorSpec` (withheld table and never-survives list, including `ARRAY -- c\n[...]`) and through the capture API in `QueryTailCaptureSpec`, where those forms are withheld while `[order] from [user]` is still recorded; the guide names the comment case. Details are in the replies on your two threads (https://github.com/apache/grails-core/pull/16631#discussion_r4366432130 and https://github.com/apache/grails-core/pull/16631#discussion_r4366432303), which I resolved; happy to reopen them if you prefer to clo se them yourself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
