borinquenkid commented on PR #16572: URL: https://github.com/apache/grails-core/pull/16572#issuecomment-6385192144
@jdaugherty, 10.0.x now carries #16695 (composite user types), so this branch conflicted. Following your checklist: - `7d7773057f` merges `10.0.x` and ports #16695's Java changes by hand into the Groovy twins: `ColumnBinder`, `CreateKeyForProps`, `ColumnNameForPropertyAndPathFetcher`, `GrailsPropertyBinder`, `HibernatePersistentProperty`, `GrailsDomainBinder`, `SimpleValueBinder`, `NumericColumnConstraintsBinder`, plus the three conflicting specs. All 21 files of #16695 are accounted for. - `e69d386b26` moves its two new classes, `CompositeUserTypeBinder` and `CompositeUserTypeColumns`: two `R100` lines, nothing else. - `0cfca82994` converts them: `@CompileStatic`, the nested `Attribute` record with the series' record options and tuple constructor, lambdas, no PMD suppression, comments and Javadoc kept. Checked locally: no `.java` left in the module apart from `JavaCallerPin`; `javap -c -p` over the new and changed classes shows only `$getStaticMetaClass`, and `Stream.toList()` is the JDK method; core 3935 tests, 1 failure (the Oracle container did not start on this machine), dbmigration-core 41/0, grails-plugin 39/0; `codenarcMain`, `rat` and `validateRepositoryConventions` clean. `no ci` is back on while the 8.0.x merge build runs; a full run comes before merge, as you asked. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
