hk2166 opened a new pull request, #16761:
URL: https://github.com/apache/grails-core/pull/16761
## Description
Fixes the links reported in #15845 and #15844 that are still broken now that
the Spring Security plugin docs live in `grails-doc`. The other links in those
reports (LDAP, CAS, Quartz and the JIRA release notes) are already gone from
the current docs.
| File (`grails-doc/src/en/guide/security/securityPlugins/springSecurity/`)
| Broken link | Now |
|---|---|---|
| `core/sessionFixation.adoc` | `jira.grails.org/browse/GRAILS-3364` (JIRA
is retired) | #4611, the migrated GRAILS-3364 issue |
| `core/sessionFixation.adoc` | `grails.org/plugin/cookie-session` (404) |
`github.com/benlucchesi/grails-cookie-session`, the plugin's repository,
renamed from `-v2` |
| `core/sessionFixation.adoc` |
`github.com/benlucchesi/grails-cookie-session-v2/issues/17` (404) |
`github.com/benlucchesi/grails-cookie-session/issues/17` |
| `ui/user.adoc` |
`apache.github.io/grails-spring-security/latest/index.html#switchUser` (404) |
`<<core-switchUser>>`, the Switch User section of this guide |
Only the link targets change. The one wording change is "this JIRA issue" →
"this issue", because the link no longer goes to JIRA.
### Verification
- `./gradlew :grails-doc:publishGuide -x aggregateGroovydoc` builds without
invalid-reference warnings.
- In the generated guide, the switch-user link renders as
`#core-switchUser`, and that anchor exists in `single.html` and in
`security.html`, which holds both the Core and UI sections. None of the old
URLs remain in the built guide.
- All three new external links return HTTP 200.
Fixes #15845
Fixes #15844
Generative AI tooling (Claude Code) was used to find the replacement links
and prepare this change.
## Contributor Checklist
Please review the following checklist before submitting your pull request.
Pull requests that do not meet these requirements may be closed without review.
### Issue and Scope
- [x] This PR is linked to an existing issue that has been **acknowledged or
approved** by the project team. If no approved issue exists, please give
background on why this change is necessary. Tickets are preferred for release
change log history.
- [x] This PR addresses the **complete scope** of the linked issue. Partial
implementations or unfinished work should not be submitted for review.
- [x] This PR contains a **single, focused change**. Unrelated changes
should be submitted as separate pull requests.
- [x] This PR targets the **correct branch** for the type of change:
- **Patch release branches** (e.g., `7.0.x`): Bug fixes only. No new
features or API changes.
- **Minor release branches** (e.g., `7.1.x`): New features are welcome,
but breaking existing APIs must be avoided.
- **Major release branches** (e.g., `8.0.x`): Reserved for major
changes. Breaking API changes are permitted.
### Code Quality
- [ ] I have **added or updated tests** that cover the changes introduced in
this PR. All code contributions are expected to include appropriate test
coverage. *(Documentation-only change; verified by building the guide, see
above.)*
- [ ] I have verified that all existing tests pass by running `./gradlew
build --rerun-tasks`. *(Not run; documentation-only change.)*
- [ ] My code follows the project's **code style** guidelines. I have run
`./gradlew codeStyle` and resolved any violations. See [Code
Style](../CONTRIBUTING.md#code-style) for details. *(Not applicable to `.adoc`
files.)*
- [x] This PR does **not** include mass reformatting, style-only changes, or
large-scale refactoring unless it was **explicitly approved** in the linked
issue. Unsolicited reformatting will not be accepted.
- [x] If generative AI tooling was used in preparing this contribution, a
quality model was used to ensure contributions are **consistent with the
project's quality standards**.
### Licensing and Attribution
- [x] All contributed code is provided under the [Apache License
2.0](https://www.apache.org/licenses/LICENSE-2.0), and new source files include
the appropriate **Apache license header**.
- [ ] I have the necessary rights to submit this contribution and confirm it
is my own original work (see [Legal
Notice](../CONTRIBUTING.md#i-want-to-contribute)).
- [x] If generative AI tooling was used in preparing this contribution, I
have followed the [Apache Software Foundation's policy on generative
tooling](https://www.apache.org/legal/generative-tooling.html) and have
properly attributed its use.
### Documentation
- [x] If this PR introduces user-facing changes, I have included or updated
the relevant documentation.
- [x] If this PR adds a new feature, I have updated the **What's New**
section of the Grails Guide.
- [x] If this PR introduces breaking changes or changes that require user
action during an upgrade, I have updated the **Upgrade Notes** for the
corresponding version in the Grails Guide.
- [x] The PR description clearly explains **what** was changed and **why**.
---
> **First-time contributors:** Please read our [Contributing
Guide](../CONTRIBUTING.md) before submitting.
> Pull requests that appear to be auto-generated, incomplete, or unrelated
to an approved issue may be
> closed to help maintainers focus on reviewed and planned work. We
appreciate your understanding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
