matrei commented on PR #16516: URL: https://github.com/apache/grails-core/pull/16516#issuecomment-6410920224
@ruthst00 I'd go with option 2. #15819 is a bug in 8.0.x and the fix for it is small, so I don't think apps on 8.0.x should have to wait for 9.0 to get it. I also don't think the split needs much surgery: **This PR, against `8.0.x`** - `GrailsDispatcherServlet` as in the sketch in point 2, which takes care of points 1 and 2. - `GrailsDispatcherServletSpec` and `GrailsDispatcherServletHiddenMethodSpec` updated to match, with the `Callable` case added. - In `UrlMappingsHandlerMappingSpec`, the late-filter feature with only the `renderTemplate` row. It should assert that rendering uses the instance in the request attribute, not the filter's. - The example app with only the `results` rows. - `UrlMappingsInfoHandlerAdapter`, `GrailsWebRequest` and `render.adoc` can simply be checked out from `8.0.x` again, and the adapter rows come out of `UrlMappingsHandlerMappingSpec`. **A new PR against `9.0.x`** - The adapter guard, `isRenderViewRequested()` (`@since 9.0.0`), the adapter rows, the `renderTemplateWithMap` row, the `resultsWithModel` and `textWithModel` rows of the example app, the `render.adoc` paragraph, and a note in `upgrading90x.adoc`. - The adapter conflicts on `9.0.x`, where #16237 added a branch for `ResponseEntity` and `@ResponseBody` values just before the `Map` branch. The guard still goes in the `Map` branch. - The late-filter rows need the dispatcher fix, so this PR can go up once the `8.0.x` part has been merged up to `9.0.x`. If you and @jdaugherty would still rather retarget the whole PR, point 1 has to be fixed there too. On `9.0.x` it also affects Grails actions that return a `StreamingResponseBody`, because #16237 streams those through the same `startCallableProcessing`. Point 2 and the guard would each need an upgrade note, and apps on 8.0.x with a late filter would keep the bug, and the workaround from the issue, until 9.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
