codeconsole commented on PR #16760: URL: https://github.com/apache/grails-core/pull/16760#issuecomment-6420666575
Addressed the skill review: `grails-9-upgrade` now has a "Spring Boot Registers the Character Encoding Filter" section after the RxJava modules, matching §20, plus the topic in the description, three checklist entries and the `HIGHEST_PRECEDENCE` pitfall (c5a90d01f3). And the three suggestions from the AI-assisted review: 1. `CHARACTER_ENCODING_FILTER`'s deprecation Javadoc now says the filters after it take their orders from their position, so they need explicit orders when it goes (f27fee3fb4). 2. §20 says the forced encoding covers parameters, `getReader()`, `request.JSON`, `request.XML` and JSON or XML body binding, which all decode with the request's encoding (ee2dbc88f5). 3. `GrailsCharacterEncodingInitializerSpec` covers an app that sets only `spring.servlet.encoding.force`, and asserts what each case logs (2edb9756a1). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
