hk2166 commented on PR #16786: URL: https://github.com/apache/grails-core/pull/16786#issuecomment-6497168247
All four points are addressed in 48f61a443b (details inline): - **The wrapped forward**: a task keeps how its request was dispatched when it started, and tasks share a copy only when they were given the same request dispatched the same way. - **The asynchronous principal**: it is taken as a dispatch ends with asynchronous processing started, still inside the filters, and a copy taken in `onComplete` keeps it. - **The body**: a task's stream and reader read the live body until the copy is taken, then go on from the copy where they stopped. - **The parameters**: only a multipart wrapper gives way to the request it wraps. On f8c3301c99, the five new unit test cases fail, each on its own point. The pubsub demo's `TaskRequestSpec` fails there for a request a filter wrapped, in Tomcat, while its unwrapped runs pass. With this commit, the module's 81 tests pass, and so do the pubsub demo's 22 integration tests. Checkstyle, CodeNarc, PMD and the repository conventions are clean, and the guide builds with the updated paragraph. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
