jdaugherty commented on PR #16795:
URL: https://github.com/apache/grails-core/pull/16795#issuecomment-6504748186
@codeconsole thanks, review 5702621723 is addressed in 40f143239e:
- `GrailsPlaceholderConfigurer`: `ConfigurationPropertyName.adapt(name,
'.')` replaces `isValid`, with an `isEmpty()` guard, and the adapted name is
passed to `Binder.bind`. A camelCase key such as `grails.cors.allowedOrigins`
resolves, and `${app.allowedOrigins}` and `${app.allowed-origins}` read the
same list.
- `GrailsPlaceholderConfigurerSpec`: a feature injecting a camelCase key
through `@Value('${grails.cors.allowedOrigins}')`, and a data-driven feature
reading a list through kebab-case, camelCase and lowercase placeholders against
the other forms of its key. Two of the four new cases fail on 7f3cf79db8; all
15 features pass on the new head.
- `config.adoc`: one sentence that the name is matched as
`@ConfigurationProperties` binding matches it.
Run locally: `:grails-core:test --tests
grails.spring.GrailsPlaceholderConfigurerSpec` and `:grails-core:codeStyle`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
