jamesfredley commented on code in PR #16794:
URL: https://github.com/apache/grails-core/pull/16794#discussion_r4417459411
##########
grails-data-docs/stage/build.gradle:
##########
@@ -105,19 +105,33 @@ tasks.register('copyHibernate5Docs', Sync).configure {
Sync it ->
it.outputs.dir(targetDir)
}
+tasks.register('copyGraphqlDocs', Sync).configure { Sync it ->
+ it.dependsOn(':grails-data-graphql-docs:docs')
+
+ def graphqlSourceDir =
project(':grails-data-graphql-docs').layout.buildDirectory.dir('docs')
+ def targetDir =
project.layout.buildDirectory.dir('graphql-api/grails-data/graphql')
+
Review Comment:
This copy publishes the GraphQL manual. Its introduction says the plugin
includes a GraphiQL browser, enabled by default in development, at
`/graphql/browser`, and the configuration table says the development default is
true. `GrailsGraphQLConfiguration` defaults `browser` to false, and
`GraphqlController` returns 404 unless the application supplies
`graphiql.html`. The manual should say the browser is off until the application
turns it on and provides that page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
