The GitHub Actions job "Groovy Snapshot Canary Build" on 
grails-core.git/fix/16007-factories-compile-inputs has failed.
Run started by GitHub user jdaugherty (triggered by jdaugherty).

Head commit for run:
51b2fdfa6fe52346952d7cbded4f7d300294ec9b / James Daugherty 
<[email protected]>
Say when the generated factories files are pruned, and what Plain is for

Review of #16780. FactoriesCompileInput and its functional spec date
from 8.0.1, the line this targets, not 9.0. The comments on the prune
and its Javadoc now say that only an incremental Groovy compilation,
which a build opts into with options.incremental = true, leaves an
entry behind for it to drop: the default compilation cleans its
destination directory before it recompiles everything.

Plain, in the factories-prune fixture, is the source that keeps the
compilation from having none once the handlers are deleted, which
would have Gradle remove every output, the generated file among them,
before the prune could. The spec now asserts that it is registered
under no type, that it is still compiled, and that the compilation
ran with nothing to compile when the file is removed.

Checking every factory type a class may belong to, rather than
stopping at the first that registers it, also registers a class that
is both an artefact handler and a trait injector under both types,
where it used to be registered as the handler alone. A spec feature
pins that.

Report URL: https://github.com/apache/grails-core/actions/runs/40930115456

With regards,
GitHub Actions via GitBox

Reply via email to