Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/232#discussion_r48842357
--- Diff: src/main/org/codehaus/groovy/classgen/asm/OperandStack.java ---
@@ -336,14 +336,12 @@ private void doConvertAndCast(ClassNode targetType,
boolean coerce) {
return;
}
box();
- } else if (primTop) {
- // top is primitive, target is not
- // so box and do groovy cast
-
controller.getInvocationWriter().castToNonPrimitiveIfNecessary(top, targetType);
} else if (primTarget) {
// top is not primitive so unbox
// leave that BH#doCast later
} else {
+ // top is primitive, target is not
+ // so box and do groovy cast
--- End diff --
the comment needs a change... "// top might be primitive, target is not"
and "// so let invocation writer box if needed and do groovy cast otherwise". I
think this case appeared to due to moving some functionality into the
invocation writer, I think before there has been really two different actions.
Well.. Still can make this change with the changed comment then of course ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
