Github user jwagenleitner commented on a diff in the pull request:
https://github.com/apache/groovy/pull/292#discussion_r56097572
--- Diff:
subprojects/groovy-sql/src/main/java/groovy/sql/BatchingStatementWrapper.java
---
@@ -34,10 +34,10 @@
* automatically. If batchSize is zero, then no batching is performed.
*/
public class BatchingStatementWrapper extends GroovyObjectSupport {
- private Statement delegate;
+ private final Statement delegate;
protected int batchSize;
protected int batchCount;
- protected Logger log;
+ protected final Logger log;
--- End diff --
While it may not be likely, there could be some subclasses that set this so
I think it might be good to avoid changing `protected` fields.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
