GitHub user jwagenleitner opened a pull request:

    https://github.com/apache/groovy/pull/356

    GROOVY-7873 - Regression performance issue in string methods

    In order to implement CharSequence the GString implementation must call 
toString each time a CharSequence method is invoked.  This is expensive, so 
GStrings should be converted toString if methods such as charAt are going to be 
called from a loop.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jwagenleitner/groovy GROOVY-7873

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/groovy/pull/356.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #356
    
----
commit 1019df6be01b1898312797534ccc8406fd4f4fad
Author: John Wagenleitner <jwagenleit...@apache.org>
Date:   2016-06-25T01:08:57Z

    GROOVY-7873 - Regression performance issue in string methods
    
    In order to implement CharSequence the GString implementation must call 
toString each time a CharSequence method is invoked.  This is expensive, so 
GStrings should be converted toString if methods such as charAt are going to be 
called from a loop.

commit 720115d7444d758f0c057ec8d47772d2ffb81154
Author: John Wagenleitner <jwagenleit...@apache.org>
Date:   2016-06-25T01:09:45Z

    GROOVY-7873 - test for demo purposes, not to be merged

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to