Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/376#discussion_r73109779
--- Diff: src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java ---
@@ -5176,7 +5176,9 @@ public static Map groupBy(Object[] self,
List<Closure> closures) {
G key = outer.getKey();
List<Map.Entry<K, V>> entries = outer.getValue();
Map<K, V> target = createSimilarMap(self);
- putAll(target, entries);
--- End diff --
my suggestion would be to change putAll to `public static <K, V> Map<K, V>
putAll(Map<K, V> self, Collection<? extends Map.Entry<? extends K, ? extends
V>> entries) `
which more or less adds `? extends` before the Map.Entry part and to change
back to use the putAll instead of the loop
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
