[ 
https://issues.apache.org/jira/browse/GROOVY-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470038#comment-16470038
 ] 

Daniel Sun edited comment on GROOVY-7204 at 5/12/18 7:34 AM:
-------------------------------------------------------------

Fixed by 
https://github.com/apache/groovy/commit/6d5bc0db7a0e8c8c69911d7e4f064e9a27ba40a6
https://github.com/apache/groovy/commit/e7766ffad4a70377a2e80b2a797261b0cb197ed4
https://github.com/apache/groovy/commit/62f5ce6ffe8d0dad30808944201723e02d3666fd
https://github.com/apache/groovy/commit/795e2540c2b8d3d62594b5c91631427c708047f6

P.S. Feel free to revert them


was (Author: daniel_sun):
Fixed by 
https://github.com/apache/groovy/commit/6d5bc0db7a0e8c8c69911d7e4f064e9a27ba40a6

P.S. Feel free to revert it

> Static type checking and compilation fail when multiple generics in use
> -----------------------------------------------------------------------
>
>                 Key: GROOVY-7204
>                 URL: https://issues.apache.org/jira/browse/GROOVY-7204
>             Project: Groovy
>          Issue Type: Bug
>          Components: Static compilation, Static Type Checker
>    Affects Versions: 2.3.8
>            Reporter: Mauro Molinari
>            Assignee: Daniel Sun
>            Priority: Critical
>             Fix For: 2.6.0-alpha-4, 3.0.0-alpha-3, 2.5.0-rc-3
>
>
> Consider the following interfaces:
> {code:title=CrudRepository.java}
> package f;
> import java.io.Serializable;
> public interface CrudRepository<T, S extends Serializable> {
>       void delete(S arg);
>       void delete(T arg);
> }
> {code}
> {code:title=MyRepository.java}
> package f;
> public interface MyRepository extends CrudRepository<String, Long> {
> }
> {code}
> The following implementation class:
> {code:title=MyRepositoryImpl.java}
> package f;
> public class MyRepositoryImpl implements MyRepository {
>       @Override
>       public void delete(String arg) {
>               System.out.println("String");
>       }
>       @Override
>       public void delete(Long arg) {
>               System.out.println("Long");
>       }
> }
> {code}
> And the following Groovy class:
> {code:title=MyClass.groovy}
> package f
> import groovy.transform.CompileStatic;
> import groovy.transform.TypeChecked;
> @TypeChecked
> class MyClass {
>       static MyRepository factory() {
>               return new MyRepositoryImpl()
>       }
>       
>       static void main(String[] args) {
>               MyRepository r = factory()
>               r.delete('foo')
>       }       
> }
> {code}
> Static type checking returns the following error:
> {noformat}
> MyClass.groovy: 15: [Static type checking] - Cannot call 
> f.MyRepository#delete(S) with arguments [java.lang.String]
> {noformat}
> The same applies if you use {{@CompileStatic}} instead of {{@TypeChecked}}.
> Note that if, In the previous code, you change the method {{main}} by 
> replacing:
> {code}
> MyRepository r = factory()
> {code}
> with: 
> {code}
> MyRepository r = new MyRepositoryImpl()
> {code}
> compilation succeeds. However in real code this might not be possible (the 
> {{MyRepository}} instance may be injected and auto-generated, think of Spring 
> Data for instance).
> The only workaround is (yet again...) to disable static type checking and 
> static compilation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to