[
https://issues.apache.org/jira/browse/GROOVY-8346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17050722#comment-17050722
]
Paul King edited comment on GROOVY-8346 at 3/4/20 2:59 AM:
-----------------------------------------------------------
We really need to change the spock generated code to look something like this:
{code}
def _temp_foo
try {
_temp_foo = 'bar'
} catch (Throwable $spock_ex) {
this.getSpecificationContext().setThrownException($spock_ex)
}
final foo = _temp_foo
{code}
but it isn't quite as simple as this in general. If instead of {{final foo =
"bar"}} you had:
{code}
final foo
if (condition) foo = "bar"
{code}
then, the naive substitution above would stop FVA picking up the real
uninitialized issue with that code.
was (Author: paulk):
We really need to change the spock generated code to look something like this:
{code}
def _temp_foo
try {
_temp_foo = 'bar'
} catch (Throwable $spock_ex) {
this.getSpecificationContext().setThrownException($spock_ex)
}
final foo = _temp_foo
{code}
> The variable [XXX] may be uninitialized
> ----------------------------------------
>
> Key: GROOVY-8346
> URL: https://issues.apache.org/jira/browse/GROOVY-8346
> Project: Groovy
> Issue Type: Bug
> Affects Versions: 2.5.0-beta-1, 2.5.0-beta-2
> Reporter: paolo di tommaso
> Priority: Major
>
> I'm getting several errors when compiling Groovy 2.5.0-beta-2 (and beta-1)
> related to final variable initialisations.
> For example:
> {code}
> [:compileTestGroovy] WorkflowMetadataTest.groovy: 43: The variable [begin]
> may be uninitialized
> [:compileTestGroovy] . At [43:15] @ line 43, column 15.
> [:compileTestGroovy] final begin = new Date()
> [:compileTestGroovy] ^
> {code}
> Related to the following line
> {code}
> final begin = new Date()
> {code}
> See also
> [here|https://github.com/nextflow-io/nextflow/blob/master/src/test/groovy/nextflow/script/WorkflowMetadataTest.groovy#L43-43],
>
> [here|https://github.com/nextflow-io/nextflow/blob/master/src/test/groovy/nextflow/file/SequentialFileStoreTest.groovy#L40-40]
>
> [here|https://github.com/nextflow-io/nextflow/blob/master/src/test/groovy/nextflow/cloud/CloudConfigTest.groovy#L299-299]
> and
> [here|https://github.com/nextflow-io/nextflow/blob/master/src/test/groovy/nextflow/processor/PublishDirTest.groovy#L96-96]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
