paulk-asert commented on pull request #1241: URL: https://github.com/apache/groovy/pull/1241#issuecomment-629619897
+1 with the following comments: - I'd suggest `@since` of 3.0.4 if merged soon - we can probably do a better error message for the case where `type` is null - no need to have in `PluginDefaultGroovyMethods` just `DefaultGroovyMethods` since we know we have JDK8+ for 3+ - perhaps a couple of additional tests for arrays of arrays, e.g.: ``` assert Arrays.equals([].stream().toArray(String[]), new String[0][]) assert Arrays.deepEquals([['x'] as String[]].stream().toArray(String[]), [['x'] as String[]] as String[][]) ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
