paulk-asert commented on a change in pull request #1309:
URL: https://github.com/apache/groovy/pull/1309#discussion_r453359180
##########
File path: src/main/java/groovy/lang/GString.java
##########
@@ -276,4 +309,16 @@ public Pattern negate() {
public byte[] getBytes(String charset) throws UnsupportedEncodingException
{
return toString().getBytes(charset);
}
+
+ private boolean checkValuesImmutable() {
+ for (Object value : values) {
+ if (null == value) continue;
+ if (!(IMMUTABLE_TYPE_LIST.contains(value.getClass())
Review comment:
Perhaps we could use ImmutablePropertyUtils#isBuiltinImmutable? We'd
have to account for primitives. Also check for enums?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
