[
https://issues.apache.org/jira/browse/GROOVY-9662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17251862#comment-17251862
]
Eric Milles edited comment on GROOVY-9662 at 12/18/20, 4:52 PM:
----------------------------------------------------------------
This is a common case where the delegation metadata does not match the runtime
resolve strategy. {{DelegatesTo}} has a default resolve strategy of
{{OWNER_FIRST}}. So by not specifying {{strategy}} attribute, the compiler
gets the default. Static compilation must choose a resolve strategy and it
relies on the annotation metadata to do so. GROOVY-9283 discusses this further.
{code:groovy}
void test(@DelegatesTo(value=Type) block) {
block.resolveStrategy = Closure.DELEGATE_FIRST
block.delegate = new Type()
block.class()
}
{code}
was (Author: emilles):
This is a common case where the delegation metadata does not match the runtime
resolve strategy. {{DelegatesTo}} has a default resolve strategy of
{{OWNER_FIRST}}. So by not specifying {{strategy}} attribute, the compiler
gets the default. Static compilation must choose a resolve strategy and it
relies on the annotation metadata to do so. I'll try to find the ticket where
this was discussed further.
{code:groovy}
void test(@DelegatesTo(value=Type) block) {
block.resolveStrategy = Closure.DELEGATE_FIRST
block.delegate = new Type()
block.class()
}
{code}
> Groovy 3.0.5: Closure delegate is not working properly
> ------------------------------------------------------
>
> Key: GROOVY-9662
> URL: https://issues.apache.org/jira/browse/GROOVY-9662
> Project: Groovy
> Issue Type: Bug
> Affects Versions: 3.0.2, 3.0.3, 3.0.4, 3.0.5, 2.5.14
> Reporter: Puneet Behl
> Assignee: Eric Milles
> Priority: Major
> Attachments: JsonViewWritableScript.groovy, StreamingJsonBuilder.java
>
>
> In Grails Views, we are using closures to generate JSON using
> `StreamingJsonBuilder`. The HAL implementation for an entity now generates an
> incorrect JSON after updating to Groovy 3.
>
> Here is the problem code snipped from
> \{{grails.plugin.json.view.api.internal.DefaultHalViewHelper#links}}:
> {code:java}
> jsonDelegate.call(LINKS_ATTRIBUTE) {
> call(SELF_ATTRIBUTE) {
> call HREF_ATTRIBUTE, viewHelper.link(resource: object, method:
> HttpMethod.GET, absolute: true)
> call HREFLANG_ATTRIBUTE, locale.toString()
> call TYPE_ATTRIBUTE, contentType
> }
> Set<Link> links = getLinks(object)
> for (link in links) {
> call(link.rel) {
> call HREF_ATTRIBUTE, link.href
> call HREFLANG_ATTRIBUTE, link.hreflang?.toString() ?:
> locale.toString()
> def linkType = link.contentType
> if (linkType) {
> call TYPE_ATTRIBUTE, linkType
> }
> }
> }
> }
> {code}
>
> Although the `resolveStatergy` for the closures is `DELEGATE_FIRST` but I
> believe that is not working correctly because it works if I change the above
> to:
> {code:java}
> delegate.call (...
> {code}
>
> To reproduce the issue please checkout
> [https://github.com/grails/grails-views/commits/bugs/groovy-9962]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
