eric-milles commented on pull request #1601: URL: https://github.com/apache/groovy/pull/1601#issuecomment-874758019
The change is definitely more palatable in size. For expression type determination during classgen, I think the `TypeChooser` should always be used. The sequence of checking expression class types and getting type or node metadata should already be provided through `TypeChooser`. Typically `TypeChecked` will provide extra checks but no changes to behavior. In this case, you are using STC info to alter the call semantics. Is there another example of this? `StaticInvocationWriter` exists specifically to provide changes for `CompileStatic` that are not applied for `TypeChecked` or regular compilation. I have not read all the treatment for this issue. Has the idea of a compiler warning been considered when you have STC on and you can detect that the argument is one of the edge cases that will not be wrapped by an array at runtime? Such a warning could be implemented as a type checking extension. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
