[GitHub] [groovy] sonatype-lift[bot] commented on a diff in pull request #1803: Polish org.codehaus.groovy.runtime package documentation

Tue, 18 Oct 2022 05:48:40 -0700 


sonatype-lift[bot] commented on code in PR #1803:
URL: https://github.com/apache/groovy/pull/1803#discussion_r998163551


##########
src/main/java/org/codehaus/groovy/runtime/metaclass/ConcurrentReaderHashMap.java:
##########
@@ -663,7 +663,7 @@ public Object remove(Object key) {
             count--;
 
             Entry head = e.next;
-            for (Entry p = first; p != e; p = p.next) 
+            for (Entry p = first; p != e; p = p.next)

Review Comment:
   *[ReferenceEquality](https://errorprone.info/bugpattern/ReferenceEquality):* 
 Comparison using reference equality instead of value equality
   
   ---
   
   
   ```suggestion
               for (Entry p = first; !p.equals(e); p = p.next)
   ```
   
   
   
   ---
   
   <details><summary><b>ℹī¸ Learn about @sonatype-lift commands</b></summary>
   
   You can reply with the following commands. For example, reply with 
***@sonatype-lift ignoreall*** to leave out all findings.
   | **Command** | **Usage** |
   | ------------- | ------------- |
   | `@sonatype-lift ignore` | Leave out the above finding from this PR |
   | `@sonatype-lift ignoreall` | Leave out all the existing findings from this 
PR |
   | `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified 
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
   
   **Note:** When talking to LiftBot, you need to **refresh** the page to see 
its response.
   <sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) 
to add LiftBot to another repo.</sub></details>
   
   
   
   ---
   
   Was this a good recommendation?
   [ [🙁 Not 
relevant](https://www.sonatype.com/lift-comment-rating?comment=346020882&lift_comment_rating=1)
 ] - [ [😕 Won't 
fix](https://www.sonatype.com/lift-comment-rating?comment=346020882&lift_comment_rating=2)
 ] - [ [😑 Not critical, will 
fix](https://www.sonatype.com/lift-comment-rating?comment=346020882&lift_comment_rating=3)
 ] - [ [🙂 Critical, will 
fix](https://www.sonatype.com/lift-comment-rating?comment=346020882&lift_comment_rating=4)
 ] - [ [😊 Critical, fixing 
now](https://www.sonatype.com/lift-comment-rating?comment=346020882&lift_comment_rating=5)
 ]



##########
src/main/java/org/codehaus/groovy/runtime/metaclass/ConcurrentReaderHashMap.java:
##########
@@ -693,7 +693,7 @@ protected Object sremove(Object key, int hash) {
         e.value = null;
         count--;
         Entry head = e.next;
-        for (Entry p = first; p != e; p = p.next) 
+        for (Entry p = first; p != e; p = p.next)

Review Comment:
   *[ReferenceEquality](https://errorprone.info/bugpattern/ReferenceEquality):* 
 Comparison using reference equality instead of value equality
   
   ---
   
   
   ```suggestion
           for (Entry p = first; !p.equals(e); p = p.next)
   ```
   
   
   
   ---
   
   <details><summary><b>ℹī¸ Learn about @sonatype-lift commands</b></summary>
   
   You can reply with the following commands. For example, reply with 
***@sonatype-lift ignoreall*** to leave out all findings.
   | **Command** | **Usage** |
   | ------------- | ------------- |
   | `@sonatype-lift ignore` | Leave out the above finding from this PR |
   | `@sonatype-lift ignoreall` | Leave out all the existing findings from this 
PR |
   | `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified 
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
   
   **Note:** When talking to LiftBot, you need to **refresh** the page to see 
its response.
   <sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) 
to add LiftBot to another repo.</sub></details>
   
   
   
   ---
   
   Was this a good recommendation?
   [ [🙁 Not 
relevant](https://www.sonatype.com/lift-comment-rating?comment=346021169&lift_comment_rating=1)
 ] - [ [😕 Won't 
fix](https://www.sonatype.com/lift-comment-rating?comment=346021169&lift_comment_rating=2)
 ] - [ [😑 Not critical, will 
fix](https://www.sonatype.com/lift-comment-rating?comment=346021169&lift_comment_rating=3)
 ] - [ [🙂 Critical, will 
fix](https://www.sonatype.com/lift-comment-rating?comment=346021169&lift_comment_rating=4)
 ] - [ [😊 Critical, fixing 
now](https://www.sonatype.com/lift-comment-rating?comment=346021169&lift_comment_rating=5)
 ]



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to