eric-milles commented on PR #1994: URL: https://github.com/apache/groovy/pull/1994#issuecomment-1826377223
Do you have some description how this will be integrated? Adding something to `ClassExpression` without changing its `transformExpression` or `visit` does not make it clear where this is going. Perhaps a description in the issue ticket before code changes would be helpful. Was it considered to use something besides a `ClassExpression` on the RHS of an `instanceof` binary expression to represent this? I'm pleased to see "p" represented by a variable expression, but the semantic of "Person" is represented in the `ClassExpression` and then again in the `PatternVariableExpression`. Where will the source ranges be associated? There is also the possibility of raising "instanceof" to a new kind of `BinaryExpression` subclass that includes the pattern-matching stuff instead of adding it to `ClassExpression`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
