[
https://issues.apache.org/jira/browse/GROOVY-11294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811471#comment-17811471
] ASF GitHub Bot commented on GROOVY-11294: ----------------------------------------- codecov-commenter commented on PR #2044: URL: https://github.com/apache/groovy/pull/2044#issuecomment-1912997552 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2044?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: `25 lines` in your changes are missing coverage. Please review. > Comparison is base [(`6b8915f`)](https://app.codecov.io/gh/apache/groovy/commit/6b8915fbd1ab898bb590caf27bfdd05d3296e7cb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 68.5474% compared to head [(`3f46926`)](https://app.codecov.io/gh/apache/groovy/pull/2044?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 68.5163%. > Report is 15 commits behind head on master. <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2044?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2044 +/- ## ================================================== - Coverage 68.5474% 68.5163% -0.0311% - Complexity 29119 29174 +55 ================================================== Files 1422 1422 Lines 113482 113535 +53 Branches 19521 19555 +34 ================================================== + Hits 77789 77790 +1 - Misses 29156 29201 +45 - Partials 6537 6544 +7 ``` | [Files](https://app.codecov.io/gh/apache/groovy/pull/2044?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ava/org/codehaus/groovy/runtime/InvokerHelper.java](https://app.codecov.io/gh/apache/groovy/pull/2044?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvSW52b2tlckhlbHBlci5qYXZh) | `70.3125% <100.0000%> (+0.1867%)` | :arrow_up: | | [...in/java/org/codehaus/groovy/vmplugin/VMPlugin.java](https://app.codecov.io/gh/apache/groovy/pull/2044?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL1ZNUGx1Z2luLmphdmE=) | `6.6667% <ø> (ø)` | | | [.../groovy/transform/RecordTypeASTTransformation.java](https://app.codecov.io/gh/apache/groovy/pull/2044?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9SZWNvcmRUeXBlQVNUVHJhbnNmb3JtYXRpb24uamF2YQ==) | `85.9649% <90.4762%> (-0.0130%)` | :arrow_down: | | [.../java/org/codehaus/groovy/vmplugin/v16/Java16.java](https://app.codecov.io/gh/apache/groovy/pull/2044?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL3YxNi9KYXZhMTYuamF2YQ==) | `51.5152% <16.6667%> (-7.7441%)` | :arrow_down: | | [...in/java/org/codehaus/groovy/vmplugin/v8/Java8.java](https://app.codecov.io/gh/apache/groovy/pull/2044?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL3Y4L0phdmE4LmphdmE=) | `76.9006% <0.0000%> (-2.2039%)` | :arrow_down: | | [...in/java/org/codehaus/groovy/vmplugin/v9/Java9.java](https://app.codecov.io/gh/apache/groovy/pull/2044?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL3Y5L0phdmE5LmphdmE=) | `59.7633% <8.3333%> (-3.9310%)` | :arrow_down: | ... and [41 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2044/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> > Make generated toList() and toMap() methods on records return immutable > collections > ----------------------------------------------------------------------------------- > > Key: GROOVY-11294 > URL: https://issues.apache.org/jira/browse/GROOVY-11294 > Project: Groovy > Issue Type: Improvement > Components: record > Affects Versions: 5.x > Reporter: Oscar N > Priority: Minor > > With records having strong immutability guarantees, I believe it would make > sense to also have the collections returned by `toList()` and `toMap()` be > immutable as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
