[
https://issues.apache.org/jira/browse/GROOVY-11560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17916886#comment-17916886
]
ASF GitHub Bot commented on GROOVY-11560:
-----------------------------------------
codecov-commenter commented on PR #2146:
URL: https://github.com/apache/groovy/pull/2146#issuecomment-2613787951
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2146?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 68.8357%. Comparing base
[(`9acdef1`)](https://app.codecov.io/gh/apache/groovy/commit/9acdef1905409974299eb9f111bfc456758c6464?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
to head
[(`e87e909`)](https://app.codecov.io/gh/apache/groovy/commit/e87e909ac57437205ca607fa095e412c678f8a84?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/2146?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #2146 +/- ##
==================================================
+ Coverage 68.8261% 68.8357% +0.0096%
- Complexity 29439 29446 +7
==================================================
Files 1420 1420
Lines 113162 113168 +6
Branches 19549 19550 +1
==================================================
+ Hits 77885 77900 +15
+ Misses 28739 28731 -8
+ Partials 6538 6537 -1
```
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/2146?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[...in/java/org/codehaus/groovy/classgen/Verifier.java](https://app.codecov.io/gh/apache/groovy/pull/2146?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fclassgen%2FVerifier.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL1ZlcmlmaWVyLmphdmE=)
| `88.8889% <100.0000%> (+0.0724%)` | :arrow_up: |
... and [3 files with indirect coverage
changes](https://app.codecov.io/gh/apache/groovy/pull/2146/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
> Invalid compiler error for class which overrides a method having duplicate
> default definitions from interfaces
> --------------------------------------------------------------------------------------------------------------
>
> Key: GROOVY-11560
> URL: https://issues.apache.org/jira/browse/GROOVY-11560
> Project: Groovy
> Issue Type: Bug
> Reporter: Eric Milles
> Assignee: Daniel Sun
> Priority: Major
> Labels: default-methods
>
> Consider the following:
> {code:java}
> package p;
> public interface A {
> default void m() {}
> }
> public interface B {
> default void m() {}
> }
> {code}
> {code:groovy}
> class C implements p.A, p.B {
> void test() {
> m()
> }
> }
> {code}
> {{groovyc}} does not detect that {{m()}} must be overridden to resolve the
> conflict. {{javac}} does produce an error, but it is still possible to
> import the interfaces from libraries and not trigger joint compilation.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
