[
https://issues.apache.org/jira/browse/GROOVY-11685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17955434#comment-17955434
]
ASF GitHub Bot commented on GROOVY-11685:
-----------------------------------------
codecov-commenter commented on PR #2243:
URL: https://github.com/apache/groovy/pull/2243#issuecomment-2925489543
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2243?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 69.0485%. Comparing base
[(`06de65f`)](https://app.codecov.io/gh/apache/groovy/commit/06de65fcdf9d558a1df541da64b67f37fd0ec9ac?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
to head
[(`67af810`)](https://app.codecov.io/gh/apache/groovy/commit/67af81026f39e8c27c98b87901bb54e5b2a4fec8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 2 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/2243?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #2243 +/- ##
==================================================
+ Coverage 69.0397% 69.0485% +0.0087%
- Complexity 29709 29714 +5
==================================================
Files 1423 1423
Lines 114437 114437
Branches 19857 19858 +1
==================================================
+ Hits 79007 79017 +10
+ Misses 28791 28784 -7
+ Partials 6639 6636 -3
```
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/2243?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[...roovy/transform/stc/StaticTypeCheckingVisitor.java](https://app.codecov.io/gh/apache/groovy/pull/2243?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2Fstc%2FStaticTypeCheckingVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9zdGMvU3RhdGljVHlwZUNoZWNraW5nVmlzaXRvci5qYXZh)
| `87.5493% <100.0000%> (ø)` | |
... and [4 files with indirect coverage
changes](https://app.codecov.io/gh/apache/groovy/pull/2243/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> Static type checking fails with groovy 5.x
> ------------------------------------------
>
> Key: GROOVY-11685
> URL: https://issues.apache.org/jira/browse/GROOVY-11685
> Project: Groovy
> Issue Type: Bug
> Affects Versions: 5.0.0-beta-1
> Reporter: Andriy Rysin
> Assignee: Eric Milles
> Priority: Major
>
> This project can compile and run under groovy-4 but fails static type
> checking with groovy-5. I could not find what would be wrong with the code.
> [https://github.com/brown-uk/nlp_uk]
> {noformat}
> org.codehaus.groovy.control.MultipleCompilationErrorsException: startup
> failed:
> file:/home/user/nlp_uk/src/main/groovy/ua/net/nlp/tools/TextUtils.groovy:
> 182: [Static type checking] - Cannot call
> java.util.function.Consumer#call(capture-o
> f ? extends ua.net.nlp.tools.TextUtils.ResultBase) with arguments
> [ua.net.nlp.tools.TextUtils$ResultBase]
> @ line 182, column 6.
> postProcessClosure(analyzed)
> ^
> file:/home/user/nlp_uk/src/main/groovy/ua/net/nlp/tools/TextUtils.groovy:
> 200: [Static type checking] - Cannot call
> java.util.function.Consumer#call(capture-o
> f ? extends ua.net.nlp.tools.TextUtils.ResultBase) with arguments
> [ua.net.nlp.tools.TextUtils$ResultBase]
> @ line 200, column 4.
> postProcessClosure(analyzed)
> ^
> file:/home/user/nlp_uk/src/main/groovy/ua/net/nlp/tools/tag/TagUnknown.groovy:
> 97: [Static type checking] - Incompatible generic argument types. Cannot
> assign
> java.util.List<java.lang.Object> to:
> java.util.List<ua.net.nlp.tools.tag.TagTextCore.TaggedToken>
> @ line 97, column 25.
> retTokens = opToTagMap.collect { e ->
> ^
> file:/home/user/nlp_uk/src/main/groovy/ua/net/nlp/tools/tag/TagUnknown.groovy:
> 136: [Static type checking] - Incompatible generic argument types. Cannot
> assig
> n java.util.List<? extends java.lang.Object> to:
> java.util.List<ua.net.nlp.tools.tag.TagTextCore.TaggedToken>
> @ line 136, column 16.
> return retTokens
> ^
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
