[
https://issues.apache.org/jira/browse/GROOVY-11711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18003811#comment-18003811
]
ASF GitHub Bot commented on GROOVY-11711:
-----------------------------------------
codecov-commenter commented on PR #2260:
URL: https://github.com/apache/groovy/pull/2260#issuecomment-3049267038
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2260?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 69.0440%. Comparing base
[(`6ebd888`)](https://app.codecov.io/gh/apache/groovy/commit/6ebd888f76a077c85294e6e01b6e2479dfc809cb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
to head
[(`82c0cac`)](https://app.codecov.io/gh/apache/groovy/commit/82c0cac10e24263b366faf99651a49ac1efe70b7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/2260?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #2260 +/- ##
==================================================
- Coverage 69.0494% 69.0440% -0.0054%
+ Complexity 29770 29768 -2
==================================================
Files 1423 1423
Lines 114437 114443 +6
Branches 19837 19839 +2
==================================================
- Hits 79018 79016 -2
- Misses 28775 28781 +6
- Partials 6644 6646 +2
```
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/2260?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[...va/org/codehaus/groovy/control/ResolveVisitor.java](https://app.codecov.io/gh/apache/groovy/pull/2260?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fcontrol%2FResolveVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NvbnRyb2wvUmVzb2x2ZVZpc2l0b3IuamF2YQ==)
| `90.1639% <100.0000%> (+0.0750%)` | :arrow_up: |
... and [4 files with indirect coverage
changes](https://app.codecov.io/gh/apache/groovy/pull/2260/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> Templates not recognized for inner classes in certain scenarios
> ---------------------------------------------------------------
>
> Key: GROOVY-11711
> URL: https://issues.apache.org/jira/browse/GROOVY-11711
> Project: Groovy
> Issue Type: Bug
> Components: Compiler
> Affects Versions: 5.0.0-beta-1
> Reporter: Saravanan
> Assignee: Eric Milles
> Priority: Minor
>
> Compiling this code
> {code:java}
> public class RecordTesting<MyTemplate1> {
> static class Blah {
> }
> class InnerClass implements List<MyTemplate1> {
> }
> }
> {code}
> results in this compile error
> {code:java}
> org.codehaus.groovy.control.MultipleCompilationErrorsException: startup
> failed:
> testdata/plugins/records/RecordTesting.java: 11: unable to resolve class
> MyTemplate1
> @ line 11, column 38.
> class InnerClass implements List<MyTemplate1> {
>
> ^testdata/plugins/records/RecordTesting.java: 11: unable to resolve class
> MyTemplate1
> @ line 11, column 38.
> class InnerClass implements List<MyTemplate1> {
> ^ {code}
> If I remove the static in front of class Blah, it will work fine. I narrowed
> this down to how the resolvevisitor tracks genericParameterNames. Without the
> static, it keeps the outer class generics in this map, but when it sees the
> static on class Blah, it clears it out. Now all inner nodes after Blah will
> see an error whenever MyTemplate1 is used. Didnt dig deeper
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
