daniellansun commented on code in PR #2276:
URL: https://github.com/apache/groovy/pull/2276#discussion_r2280900907
##########
build-logic/src/main/groovy/org.apache.groovy-tested.gradle:
##########
@@ -70,11 +70,9 @@ tasks.withType(Test).configureEach {
userHome: temporaryDir // make sure tests are isolated from real user
home or tests using Grape may fail
))
- if (rootProject.hasProperty('target.java.home')) {
- String targetJavaHome =
rootProject.property('target.java.home')?.trim()
- if (targetJavaHome) {
- executable = "${targetJavaHome}/bin/java"
- println "Using ${executable} to run tests"
+ if (rootProject.hasProperty('test.java.ea')) {
+ javaLauncher = javaToolchains.launcherFor {
+ languageVersion = JavaLanguageVersion.of(25)
Review Comment:
It's better to pass the java version via arguments to achieve better
flexibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
