[
https://issues.apache.org/jira/browse/GROOVY-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18018450#comment-18018450
]
ASF GitHub Bot commented on GROOVY-11745:
-----------------------------------------
codecov-commenter commented on PR #2288:
URL: https://github.com/apache/groovy/pull/2288#issuecomment-3259195152
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2288?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:x: Patch coverage is `50.00000%` with `2 lines` in your changes missing
coverage. Please review.
:white_check_mark: Project coverage is 66.9944%. Comparing base
([`dd37d71`](https://app.codecov.io/gh/apache/groovy/commit/dd37d71e9739a6ad3219c76643ea1f7d8bb33a49?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`3f8f996`](https://app.codecov.io/gh/apache/groovy/commit/3f8f996ae75b0a6ea56ee958bbecbb7ced967449?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/2288?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Patch % | Lines |
|---|---|---|
|
[src/main/java/groovy/lang/MetaClassImpl.java](https://app.codecov.io/gh/apache/groovy/pull/2288?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Flang%2FMetaClassImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvbGFuZy9NZXRhQ2xhc3NJbXBsLmphdmE=)
| 50.0000% | [0 Missing and 2 partials :warning:
](https://app.codecov.io/gh/apache/groovy/pull/2288?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/2288?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #2288 +/- ##
==================================================
+ Coverage 66.9933% 66.9944% +0.0011%
Complexity 29290 29290
==================================================
Files 1382 1382
Lines 116546 116547 +1
Branches 20404 20404
==================================================
+ Hits 78078 78080 +2
Misses 32050 32050
+ Partials 6418 6417 -1
```
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/2288?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[src/main/java/groovy/lang/MetaClassImpl.java](https://app.codecov.io/gh/apache/groovy/pull/2288?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Flang%2FMetaClassImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvbGFuZy9NZXRhQ2xhc3NJbXBsLmphdmE=)
| `78.1868% <50.0000%> (-0.0980%)` | :arrow_down: |
... and [3 files with indirect coverage
changes](https://app.codecov.io/gh/apache/groovy/pull/2288/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> Groovy5 calling Groovy4 library with setter throws NPE
> ------------------------------------------------------
>
> Key: GROOVY-11745
> URL: https://issues.apache.org/jira/browse/GROOVY-11745
> Project: Groovy
> Issue Type: Bug
> Affects Versions: 4.0.28, 5.0.0
> Reporter: Aleks Tamarkin
> Assignee: Eric Milles
> Priority: Major
>
> When Groovy5 calls Groovy4 code that sets a property which should be calling
> a setter under the hood, an NPE is thrown.
> The stack looks like
>
> {code:java}
> Exception in thread "main" java.lang.NullPointerException
> at java.base/java.lang.Class.isAssignableFrom(Native Method)
> at groovy.lang.MetaClassImpl.isVisibleProperty(MetaClassImpl.java:2104)
> at groovy.lang.MetaClassImpl.setProperty(MetaClassImpl.java:2761)
> at
> org.codehaus.groovy.runtime.ScriptBytecodeAdapter.setProperty(ScriptBytecodeAdapter.java:509){code}
> I am seeing this error fairly randomly on setters.
> One example in the Groovy4 code being called by Groovy5 looks like
> {code:java}
> HttpURLConnection c = "<someUrl>".toURL().openConnection() as
> HttpURLConnection
> ...
> c.useCaches = false // this line has the error{code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
