[
https://issues.apache.org/jira/browse/GROOVY-8659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18020709#comment-18020709
] ASF GitHub Bot commented on GROOVY-8659: ---------------------------------------- codecov-commenter commented on PR #2294: URL: https://github.com/apache/groovy/pull/2294#issuecomment-3299421449 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2294?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `93.75000%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 67.0063%. Comparing base ([`21c0fc7`](https://app.codecov.io/gh/apache/groovy/commit/21c0fc7e7aff6281a21911307832552cd441df83?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`99a19eb`](https://app.codecov.io/gh/apache/groovy/commit/99a19ebe79666ee5ae74bdda58065a95546f12a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2294?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...in/java/org/codehaus/groovy/classgen/Verifier.java](https://app.codecov.io/gh/apache/groovy/pull/2294?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fclassgen%2FVerifier.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL1ZlcmlmaWVyLmphdmE=) | 93.7500% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2294?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2294?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2294 +/- ## ================================================== + Coverage 67.0009% 67.0063% +0.0054% - Complexity 29301 29310 +9 ================================================== Files 1382 1382 Lines 116591 116601 +10 Branches 20410 20410 ================================================== + Hits 78117 78130 +13 + Misses 32050 32049 -1 + Partials 6424 6422 -2 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2294?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...in/java/org/codehaus/groovy/classgen/Verifier.java](https://app.codecov.io/gh/apache/groovy/pull/2294?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fclassgen%2FVerifier.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL1ZlcmlmaWVyLmphdmE=) | `89.7727% <93.7500%> (+0.0024%)` | :arrow_up: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2294/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > Base class has final getter; extending class has property of same name; no > warning for final override > ----------------------------------------------------------------------------------------------------- > > Key: GROOVY-8659 > URL: https://issues.apache.org/jira/browse/GROOVY-8659 > Project: Groovy > Issue Type: Question > Reporter: Eric Milles > Assignee: Eric Milles > Priority: Major > > Possibly related to GROOVY-8188, this is more of a question than a bug at > this point. Should it be an error to have a class extend another with a > final method and provide a property of the same name? > {code:groovy} > class Foo { > final Object getProp() {} > } > class Bar extends Foo { > Object prop = 0; // Should this be a similar error? > //Object getProp() {} // would be "You are not allowed to override the > final method getProp() from class 'Foo'." > } > {code} > Executing {{new Bar().prop}} returns null (from the final method); {{new > Bar().@prop}} returns 0. -- This message was sent by Atlassian Jira (v8.20.10#820010)
