[
https://issues.apache.org/jira/browse/GROOVY-11513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18048809#comment-18048809
]
ASF GitHub Bot commented on GROOVY-11513:
-----------------------------------------
codecov-commenter commented on PR #2156:
URL: https://github.com/apache/groovy/pull/2156#issuecomment-3706667726
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2156?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 68.8568%. Comparing base
([`6371978`](https://app.codecov.io/gh/apache/groovy/commit/6371978287eb91f4b16a02d84b2a3d5a00318a1b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`34dc1fe`](https://app.codecov.io/gh/apache/groovy/commit/34dc1feee29c6b0ceb3b9389878bfee275f411a0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 662 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/2156?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #2156 +/- ##
==================================================
+ Coverage 68.8471% 68.8568% +0.0097%
- Complexity 29487 29489 +2
==================================================
Files 1421 1421
Lines 113264 113264
Branches 19584 19584
==================================================
+ Hits 77979 77990 +11
+ Misses 28737 28729 -8
+ Partials 6548 6545 -3
```
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/2156?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[...va/org/codehaus/groovy/control/ResolveVisitor.java](https://app.codecov.io/gh/apache/groovy/pull/2156?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fcontrol%2FResolveVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NvbnRyb2wvUmVzb2x2ZVZpc2l0b3IuamF2YQ==)
| `90.0383% <100.0000%> (ø)` | |
... and [2 files with indirect coverage
changes](https://app.codecov.io/gh/apache/groovy/pull/2156/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> java.time.* should be imported automatically
> --------------------------------------------
>
> Key: GROOVY-11513
> URL: https://issues.apache.org/jira/browse/GROOVY-11513
> Project: Groovy
> Issue Type: Improvement
> Components: Compiler
> Affects Versions: 4.0.23
> Reporter: Scott Murphy Heiberg
> Assignee: Eric Milles
> Priority: Major
> Labels: breaking
> Fix For: 5.0.0-beta-2
>
>
> if java.time is the recommended way to proceed forward when dealing with
> dates,
> java.time.* should be included automatically similar to how java.util.Date is
> currently available without import.
> The preferred approach would be to make it a global import which would be in
> line with existing Groovy handling of java.util.Date
>
> The least invasive approach would be to make the import only apply if
> groovy-datetime module has been added.
>
> implementation "org.apache.groovy:groovy-datetime"
>
> should automatically import java.time.* to all classes
>
> This provides an easier migration path from Date -> DateTIme
> [https://groovy.apache.org/blog/groovy-dates-and-times-cheat]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
