[
https://issues.apache.org/jira/browse/GROOVY-6526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18061987#comment-18061987
] ASF GitHub Bot commented on GROOVY-6526: ---------------------------------------- codecov-commenter commented on PR #2388: URL: https://github.com/apache/groovy/pull/2388#issuecomment-3981112850 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2388?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `84.84848%` with `5 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 66.7402%. Comparing base ([`71b6eb9`](https://app.codecov.io/gh/apache/groovy/commit/71b6eb9a534f67b68d08953562c2a02f30217d1c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`62d0f8b`](https://app.codecov.io/gh/apache/groovy/commit/62d0f8bda9b1b2db99fd286ed3c393a0f5c7f936?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2388?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...n/java/org/codehaus/groovy/ast/AnnotationNode.java](https://app.codecov.io/gh/apache/groovy/pull/2388?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fast%2FAnnotationNode.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2FzdC9Bbm5vdGF0aW9uTm9kZS5qYXZh) | 86.2069% | [1 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...in/java/org/codehaus/groovy/vmplugin/v8/Java8.java](https://app.codecov.io/gh/apache/groovy/pull/2388?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fvmplugin%2Fv8%2FJava8.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL3Y4L0phdmE4LmphdmE=) | 75.0000% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2388 +/- ## ================================================== - Coverage 66.7554% 66.7402% -0.0152% - Complexity 29854 29863 +9 ================================================== Files 1382 1382 Lines 116136 116134 -2 Branches 20475 20477 +2 ================================================== - Hits 77527 77508 -19 - Misses 32277 32288 +11 - Partials 6332 6338 +6 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2388?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...rg/codehaus/groovy/ast/decompiled/Annotations.java](https://app.codecov.io/gh/apache/groovy/pull/2388?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fast%2Fdecompiled%2FAnnotations.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2FzdC9kZWNvbXBpbGVkL0Fubm90YXRpb25zLmphdmE=) | `89.8551% <ø> (-0.1449%)` | :arrow_down: | | [.../java/org/codehaus/groovy/vmplugin/v16/Java16.java](https://app.codecov.io/gh/apache/groovy/pull/2388?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fvmplugin%2Fv16%2FJava16.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL3YxNi9KYXZhMTYuamF2YQ==) | `56.0000% <ø> (-3.2593%)` | :arrow_down: | | [...in/java/org/codehaus/groovy/vmplugin/v9/Java9.java](https://app.codecov.io/gh/apache/groovy/pull/2388?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fvmplugin%2Fv9%2FJava9.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL3Y5L0phdmE5LmphdmE=) | `59.7222% <ø> (-0.5517%)` | :arrow_down: | | [...in/java/org/codehaus/groovy/vmplugin/v8/Java8.java](https://app.codecov.io/gh/apache/groovy/pull/2388?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fvmplugin%2Fv8%2FJava8.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL3Y4L0phdmE4LmphdmE=) | `76.7296% <75.0000%> (-0.9830%)` | :arrow_down: | | [...n/java/org/codehaus/groovy/ast/AnnotationNode.java](https://app.codecov.io/gh/apache/groovy/pull/2388?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fast%2FAnnotationNode.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2FzdC9Bbm5vdGF0aW9uTm9kZS5qYXZh) | `75.2577% <86.2069%> (+2.0183%)` | :arrow_up: | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2388/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > AnnotationNode.isTargetAllowed returns true for any value > --------------------------------------------------------- > > Key: GROOVY-6526 > URL: https://issues.apache.org/jira/browse/GROOVY-6526 > Project: Groovy > Issue Type: Bug > Components: Compiler > Affects Versions: 2.2.1 > Reporter: Andres Almiray > Assignee: Eric Milles > Priority: Major > Labels: annotations > > As the title says, invoking {{isTargetAllowed()}} with any of the accepted > target constants always returns true, completely disregarding any values that > the annotation may have. For example > {code} > @Retention(RetentionPolicy.RUNTIME) > @Target(ElementType.METHOD) > public @interface Threading { > } > {code} > {code} > AnnotationNode annotation = classNode.getAnnotation(Threading.class) > assert annotationNode.isTargetAllowed(AnnotationNode.FIELD_TARGET) // passes! > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)
