[
https://issues.apache.org/jira/browse/GROOVY-11885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18069178#comment-18069178
] ASF GitHub Bot commented on GROOVY-11885: ----------------------------------------- codecov-commenter commented on PR #2408: URL: https://github.com/apache/groovy/pull/2408#issuecomment-4146355075 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2408?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `83.33333%` with `5 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 66.4297%. Comparing base ([`88afe5b`](https://app.codecov.io/gh/apache/groovy/commit/88afe5b28c3b902f4feddc2a514d177c749c217b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c46fe77`](https://app.codecov.io/gh/apache/groovy/commit/c46fe77cc0f3db02f9b0764895ad4dfbd0cdcbbd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../ClosureExpressionEvaluationASTTransformation.java](https://app.codecov.io/gh/apache/groovy/pull/2408?src=pr&el=tree&filepath=subprojects%2Fgroovy-contracts%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fcontracts%2Fast%2FClosureExpressionEvaluationASTTransformation.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWNvbnRyYWN0cy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ3Jvb3Z5L2NvbnRyYWN0cy9hc3QvQ2xvc3VyZUV4cHJlc3Npb25FdmFsdWF0aW9uQVNUVHJhbnNmb3JtYXRpb24uamF2YQ==) | 85.0000% | [0 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2408?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/groovy/contracts/generation/CandidateChecks.java](https://app.codecov.io/gh/apache/groovy/pull/2408?src=pr&el=tree&filepath=subprojects%2Fgroovy-contracts%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fcontracts%2Fgeneration%2FCandidateChecks.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWNvbnRyYWN0cy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ3Jvb3Z5L2NvbnRyYWN0cy9nZW5lcmF0aW9uL0NhbmRpZGF0ZUNoZWNrcy5qYXZh) | 80.0000% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2408?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2408?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## groovy11884 #2408 +/- ## ===================================================== + Coverage 66.4248% 66.4297% +0.0049% - Complexity 29906 29916 +10 ===================================================== Files 1393 1393 Lines 116869 116898 +29 Branches 20682 20691 +9 ===================================================== + Hits 77630 77655 +25 - Misses 32871 32872 +1 - Partials 6368 6371 +3 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2408?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...e/groovy/contracts/generation/CandidateChecks.java](https://app.codecov.io/gh/apache/groovy/pull/2408?src=pr&el=tree&filepath=subprojects%2Fgroovy-contracts%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fcontracts%2Fgeneration%2FCandidateChecks.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWNvbnRyYWN0cy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ3Jvb3Z5L2NvbnRyYWN0cy9nZW5lcmF0aW9uL0NhbmRpZGF0ZUNoZWNrcy5qYXZh) | `64.5161% <80.0000%> (+9.9707%)` | :arrow_up: | | [.../ClosureExpressionEvaluationASTTransformation.java](https://app.codecov.io/gh/apache/groovy/pull/2408?src=pr&el=tree&filepath=subprojects%2Fgroovy-contracts%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fcontracts%2Fast%2FClosureExpressionEvaluationASTTransformation.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWNvbnRyYWN0cy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ3Jvb3Z5L2NvbnRyYWN0cy9hc3QvQ2xvc3VyZUV4cHJlc3Npb25FdmFsdWF0aW9uQVNUVHJhbnNmb3JtYXRpb24uamF2YQ==) | `90.9091% <85.0000%> (-4.9242%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2408/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > groovy-contacts could support scripts > ------------------------------------- > > Key: GROOVY-11885 > URL: https://issues.apache.org/jira/browse/GROOVY-11885 > Project: Groovy > Issue Type: Improvement > Reporter: Paul King > Assignee: Paul King > Priority: Major > > Currently, groovy-contracts explicitly skips scripts. This was a design > choice at the time, but there are times when pre and post-conditions on > scripts would also be useful. -- This message was sent by Atlassian Jira (v8.20.10#820010)
