[
https://issues.apache.org/jira/browse/GROOVY-11887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18069244#comment-18069244
] ASF GitHub Bot commented on GROOVY-11887: ----------------------------------------- codecov-commenter commented on PR #2411: URL: https://github.com/apache/groovy/pull/2411#issuecomment-4148019261 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2411?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `74.19355%` with `8 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 66.4043%. Comparing base ([`e5dc35d`](https://app.codecov.io/gh/apache/groovy/commit/e5dc35d7503c83b25d770b71086bb121b4d8d874?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`093111e`](https://app.codecov.io/gh/apache/groovy/commit/093111ef6ecd97461ebcde2595ec68a4a3debd96?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2411?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...oovy/junit5/plugin/GroovyConditionExtension.groovy](https://app.codecov.io/gh/apache/groovy/pull/2411?src=pr&el=tree&filepath=subprojects%2Fgroovy-test-junit5%2Fsrc%2Fmain%2Fgroovy%2Fgroovy%2Fjunit5%2Fplugin%2FGroovyConditionExtension.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LXRlc3QtanVuaXQ1L3NyYy9tYWluL2dyb292eS9ncm9vdnkvanVuaXQ1L3BsdWdpbi9Hcm9vdnlDb25kaXRpb25FeHRlbnNpb24uZ3Jvb3Z5) | 65.2174% | [2 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2411?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2411?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2411 +/- ## ================================================== + Coverage 66.4014% 66.4043% +0.0029% - Complexity 29893 29902 +9 ================================================== Files 1393 1395 +2 Lines 116844 116875 +31 Branches 20675 20684 +9 ================================================== + Hits 77586 77610 +24 - Misses 32892 32894 +2 - Partials 6366 6371 +5 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2411?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...vy/junit5/plugin/ConditionEvaluationContext.groovy](https://app.codecov.io/gh/apache/groovy/pull/2411?src=pr&el=tree&filepath=subprojects%2Fgroovy-test-junit5%2Fsrc%2Fmain%2Fgroovy%2Fgroovy%2Fjunit5%2Fplugin%2FConditionEvaluationContext.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LXRlc3QtanVuaXQ1L3NyYy9tYWluL2dyb292eS9ncm9vdnkvanVuaXQ1L3BsdWdpbi9Db25kaXRpb25FdmFsdWF0aW9uQ29udGV4dC5ncm9vdnk=) | `100.0000% <100.0000%> (ø)` | | | [...oovy/junit5/plugin/GroovyConditionExtension.groovy](https://app.codecov.io/gh/apache/groovy/pull/2411?src=pr&el=tree&filepath=subprojects%2Fgroovy-test-junit5%2Fsrc%2Fmain%2Fgroovy%2Fgroovy%2Fjunit5%2Fplugin%2FGroovyConditionExtension.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LXRlc3QtanVuaXQ1L3NyYy9tYWluL2dyb292eS9ncm9vdnkvanVuaXQ1L3BsdWdpbi9Hcm9vdnlDb25kaXRpb25FeHRlbnNpb24uZ3Jvb3Z5) | `65.2174% <65.2174%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2411/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > Scripting support for JUnit5 conditional execution > -------------------------------------------------- > > Key: GROOVY-11887 > URL: https://issues.apache.org/jira/browse/GROOVY-11887 > Project: Groovy > Issue Type: New Feature > Reporter: Paul King > Assignee: Paul King > Priority: Major > > JUnit used to support @EnabledIf scripting (and @DisabledIf) where a String > would be evaluated using e.g. JavaScript. This was deprecated in 5.5 and > removed in 5.6. Instead in 5.7, a different @EnabledIf was introduced that > point to a method name. The original scripting support was removed when > JavaScript support was dropped but also since it was seen as a potential > security issue. Groovy users are more familiar with using scripting in secure > ways and do have a scripting language available, so this issue will look at > adding @GroovyEnabledIf and @GroovyDisabledIf annotations to bring back the > scripting support. -- This message was sent by Atlassian Jira (v8.20.10#820010)
