[
https://issues.apache.org/jira/browse/GROOVY-11890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18069796#comment-18069796
] ASF GitHub Bot commented on GROOVY-11890: ----------------------------------------- codecov-commenter commented on PR #2422: URL: https://github.com/apache/groovy/pull/2422#issuecomment-4160285064 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2422?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `52.00000%` with `36 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 66.3564%. Comparing base ([`e1e3d9e`](https://app.codecov.io/gh/apache/groovy/commit/e1e3d9e2be808c76350ede32224e25aa9ddb1d8c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ced0018`](https://app.codecov.io/gh/apache/groovy/commit/ced001875b70816136e48f6474cb89503d9e07e9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2422?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...vy/contracts/ast/LoopVariantASTTransformation.java](https://app.codecov.io/gh/apache/groovy/pull/2422?src=pr&el=tree&filepath=subprojects%2Fgroovy-contracts%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fcontracts%2Fast%2FLoopVariantASTTransformation.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWNvbnRyYWN0cy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ3Jvb3Z5L2NvbnRyYWN0cy9hc3QvTG9vcFZhcmlhbnRBU1RUcmFuc2Zvcm1hdGlvbi5qYXZh) | 62.7119% | [10 Missing and 12 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2422?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../apache/groovy/contracts/LoopVariantViolation.java](https://app.codecov.io/gh/apache/groovy/pull/2422?src=pr&el=tree&filepath=subprojects%2Fgroovy-contracts%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fcontracts%2FLoopVariantViolation.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWNvbnRyYWN0cy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ3Jvb3Z5L2NvbnRyYWN0cy9Mb29wVmFyaWFudFZpb2xhdGlvbi5qYXZh) | 12.5000% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2422?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2422?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2422 +/- ## ================================================== - Coverage 66.3682% 66.3564% -0.0118% - Complexity 29881 29890 +9 ================================================== Files 1393 1395 +2 Lines 116827 116902 +75 Branches 20668 20679 +11 ================================================== + Hits 77536 77572 +36 - Misses 32930 32956 +26 - Partials 6361 6374 +13 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2422?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/groovy/contracts/LoopVariantViolation.java](https://app.codecov.io/gh/apache/groovy/pull/2422?src=pr&el=tree&filepath=subprojects%2Fgroovy-contracts%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fcontracts%2FLoopVariantViolation.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWNvbnRyYWN0cy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ3Jvb3Z5L2NvbnRyYWN0cy9Mb29wVmFyaWFudFZpb2xhdGlvbi5qYXZh) | `12.5000% <12.5000%> (ø)` | | | [...vy/contracts/ast/LoopVariantASTTransformation.java](https://app.codecov.io/gh/apache/groovy/pull/2422?src=pr&el=tree&filepath=subprojects%2Fgroovy-contracts%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fcontracts%2Fast%2FLoopVariantASTTransformation.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWNvbnRyYWN0cy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ3Jvb3Z5L2NvbnRyYWN0cy9hc3QvTG9vcFZhcmlhbnRBU1RUcmFuc2Zvcm1hdGlvbi5qYXZh) | `62.7119% <62.7119%> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2422/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > groovy-contracts could support "@Decreases" > ------------------------------------------- > > Key: GROOVY-11890 > URL: https://issues.apache.org/jira/browse/GROOVY-11890 > Project: Groovy > Issue Type: Improvement > Reporter: Paul King > Priority: Major > > Looking at various Dafny examples, the next most used mechanism is > _decreases_ typically related to the loop condition. groovy-contracts could > support a @Decreases annotation that would allow such termination conditions > to be asserted. -- This message was sent by Atlassian Jira (v8.20.10#820010)
