[
https://issues.apache.org/jira/browse/GROOVY-11893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18069965#comment-18069965
] ASF GitHub Bot commented on GROOVY-11893: ----------------------------------------- codecov-commenter commented on PR #2424: URL: https://github.com/apache/groovy/pull/2424#issuecomment-4163525046 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2424?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `60.00000%` with `20 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 66.3844%. Comparing base ([`c67a68d`](https://app.codecov.io/gh/apache/groovy/commit/c67a68d7a899279ec7c4a92a56e4a85c31bcfeaa?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`592165b`](https://app.codecov.io/gh/apache/groovy/commit/592165ba086f1ffd57c5675a7fa39c8b8e2e29c3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 2 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2424?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...java/org/codehaus/groovy/runtime/FormatHelper.java](https://app.codecov.io/gh/apache/groovy/pull/2424?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FFormatHelper.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvRm9ybWF0SGVscGVyLmphdmE=) | 63.4146% | [9 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2424?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../codehaus/groovy/runtime/DefaultGroovyMethods.java](https://app.codecov.io/gh/apache/groovy/pull/2424?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FDefaultGroovyMethods.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvRGVmYXVsdEdyb292eU1ldGhvZHMuamF2YQ==) | 37.5000% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2424?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2424?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2424 +/- ## ================================================== + Coverage 66.3840% 66.3844% +0.0004% - Complexity 29901 29918 +17 ================================================== Files 1394 1394 Lines 116876 116916 +40 Branches 20675 20684 +9 ================================================== + Hits 77587 77614 +27 - Misses 32926 32930 +4 - Partials 6363 6372 +9 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2424?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...rg/codehaus/groovy/runtime/ArrayGroovyMethods.java](https://app.codecov.io/gh/apache/groovy/pull/2424?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FArrayGroovyMethods.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvQXJyYXlHcm9vdnlNZXRob2RzLmphdmE=) | `89.7546% <100.0000%> (+0.0063%)` | :arrow_up: | | [.../codehaus/groovy/runtime/DefaultGroovyMethods.java](https://app.codecov.io/gh/apache/groovy/pull/2424?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FDefaultGroovyMethods.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvRGVmYXVsdEdyb292eU1ldGhvZHMuamF2YQ==) | `74.7745% <37.5000%> (-0.0870%)` | :arrow_down: | | [...java/org/codehaus/groovy/runtime/FormatHelper.java](https://app.codecov.io/gh/apache/groovy/pull/2424?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FFormatHelper.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvRm9ybWF0SGVscGVyLmphdmE=) | `80.0885% <63.4146%> (+1.9635%)` | :arrow_up: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2424/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > Standardise hooks for Groovy pretty printing > -------------------------------------------- > > Key: GROOVY-11893 > URL: https://issues.apache.org/jira/browse/GROOVY-11893 > Project: Groovy > Issue Type: Improvement > Reporter: Paul King > Assignee: Paul King > Priority: Major > > Groovy has special hard-coded handling when printing lists, maps and in some > cases arrays. There have been proposals for disabling this, e.g. part of: > https://github.com/apache/groovy/pull/566 > This issue is to look at a more general approach to handling such cases > including the ability to disable the special handling and fall back to JDK > default formatting for e.g. maps. > The idea that will be explored is to have groovyToString extension methods. > They would encode the current hard-coded formatting behavior. These > extensions could be disabled using the groovy.extension.disable system > property to fall back to JDK defaults. > Note that currently not all paths funnel through a single path that we can > fix using this mechanism. Printing some objects through inspect does things > like limit length and escape backslashes etc. Currently, we don't try to > force those through this mechanism. -- This message was sent by Atlassian Jira (v8.20.10#820010)
