[
https://issues.apache.org/jira/browse/GROOVY-11342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18070167#comment-18070167
] ASF GitHub Bot commented on GROOVY-11342: ----------------------------------------- codecov-commenter commented on PR #2070: URL: https://github.com/apache/groovy/pull/2070#issuecomment-4166330325 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2070?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `48.71795%` with `20 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 68.5850%. Comparing base ([`62776a3`](https://app.codecov.io/gh/apache/groovy/commit/62776a3b575b2c5e7acfcf05cca06cf9674bb2a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`79f9ff3`](https://app.codecov.io/gh/apache/groovy/commit/79f9ff3f9d3802412f288df890a9e196a16d4498?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1453 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2070?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...jects/groovy-sql/src/main/java/groovy/sql/Sql.java](https://app.codecov.io/gh/apache/groovy/pull/2070?src=pr&el=tree&filepath=subprojects%2Fgroovy-sql%2Fsrc%2Fmain%2Fjava%2Fgroovy%2Fsql%2FSql.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LXNxbC9zcmMvbWFpbi9qYXZhL2dyb292eS9zcWwvU3FsLmphdmE=) | 48.7180% | [18 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2070?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2070?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2070 +/- ## ================================================== - Coverage 68.5864% 68.5850% -0.0014% - Complexity 29193 29195 +2 ================================================== Files 1422 1422 Lines 113384 113395 +11 Branches 19527 19527 ================================================== + Hits 77766 77772 +6 - Misses 29074 29081 +7 + Partials 6544 6542 -2 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2070?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...jects/groovy-sql/src/main/java/groovy/sql/Sql.java](https://app.codecov.io/gh/apache/groovy/pull/2070?src=pr&el=tree&filepath=subprojects%2Fgroovy-sql%2Fsrc%2Fmain%2Fjava%2Fgroovy%2Fsql%2FSql.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LXNxbC9zcmMvbWFpbi9qYXZhL2dyb292eS9zcWwvU3FsLmphdmE=) | `64.7217% <48.7180%> (-0.4641%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2070/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > SQL enhancement to allow metadata access for execute > ---------------------------------------------------- > > Key: GROOVY-11342 > URL: https://issues.apache.org/jira/browse/GROOVY-11342 > Project: Groovy > Issue Type: Improvement > Reporter: Paul King > Assignee: Paul King > Priority: Major > Fix For: 5.0.0-alpha-8, 4.0.21 > > Attachments: SqlExamples2.groovy > > > See: > https://lists.apache.org/thread/3xgm7p2nlv8zz6n9cnpgsmdgzjtojz2v > There are 5 variants of {{execute}} which take a {{processResults}} Closure. > I imagine we would leave those as is and add 5 new variants that would also > take a meta Closure. -- This message was sent by Atlassian Jira (v8.20.10#820010)
