[
https://issues.apache.org/jira/browse/GROOVY-11901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18070937#comment-18070937
] ASF GitHub Bot commented on GROOVY-11901: ----------------------------------------- codecov-commenter commented on PR #2431: URL: https://github.com/apache/groovy/pull/2431#issuecomment-4185632885 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2431?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `77.52809%` with `20 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 66.3376%. Comparing base ([`e85473e`](https://app.codecov.io/gh/apache/groovy/commit/e85473e6daf46a8ea38a5993f8c6b24e50fb0d75?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`444da21`](https://app.codecov.io/gh/apache/groovy/commit/444da21a74c53e7d87f5515b80ea21f2518b53ed?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2431?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../codehaus/groovy/runtime/ProcessGroovyMethods.java](https://app.codecov.io/gh/apache/groovy/pull/2431?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FProcessGroovyMethods.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvUHJvY2Vzc0dyb292eU1ldGhvZHMuamF2YQ==) | 76.7123% | [9 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2431?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ava/org/codehaus/groovy/runtime/ProcessResult.java](https://app.codecov.io/gh/apache/groovy/pull/2431?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FProcessResult.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvUHJvY2Vzc1Jlc3VsdC5qYXZh) | 81.2500% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2431?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2431?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2431 +/- ## ================================================== + Coverage 66.3214% 66.3376% +0.0162% - Complexity 29943 29975 +32 ================================================== Files 1396 1397 +1 Lines 117119 117208 +89 Branches 20740 20758 +18 ================================================== + Hits 77675 77753 +78 + Misses 33060 33059 -1 - Partials 6384 6396 +12 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2431?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...ava/org/codehaus/groovy/runtime/ProcessResult.java](https://app.codecov.io/gh/apache/groovy/pull/2431?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FProcessResult.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvUHJvY2Vzc1Jlc3VsdC5qYXZh) | `81.2500% <81.2500%> (ø)` | | | [.../codehaus/groovy/runtime/ProcessGroovyMethods.java](https://app.codecov.io/gh/apache/groovy/pull/2431?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FProcessGroovyMethods.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvUHJvY2Vzc0dyb292eU1ldGhvZHMuamF2YQ==) | `79.8283% <76.7123%> (+5.4533%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2431/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > Renovate process handling methods > --------------------------------- > > Key: GROOVY-11901 > URL: https://issues.apache.org/jira/browse/GROOVY-11901 > Project: Groovy > Issue Type: Improvement > Reporter: Paul King > Assignee: Paul King > Priority: Major > > Groovy's methods for process handling were created prior to the JDK having > ProcessBuilder. We shouldn't replicate what it provides but there is plenty > of scope to add a minimal Groovy-friendly facade in some cases. > h3. Non-goals > - Don't reimplement ProcessBuilder features > - Don't break existing functionality > - Leverage ProcessBuilder's fluent API when needed rather than proliferate > extra extension methods -- This message was sent by Atlassian Jira (v8.20.10#820010)
